thermal: qcom: tsens: Add interrupt support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest15 patches 1 replyIn review
- v615 patches 8 repliesSuperseded
- v415 patches 9 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 15 patches | 2 replies | Superseded | |
| v2 | 15 patches | 25 replies | Superseded | |
| v1 | 15 patches | 36 replies | Superseded |
Changes in v7 from the cover letter
- Stephen reported a warning that only shows up with gcc 9.x
(https://lore.kernel.org/lkml/CAHLCerOkeOEEUgtJ=YgDKKXDiyFXHQ4LBdzg3-3VtKvpyceqFg@mail.gmail.com/). Include a patch to initialise the index variable to zero.
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | drivers: thermal: tsens: Get rid of id field in tsens_sensordrivers/ drivers/ drivers/ +1 more | +20 | 0 replies | |
| 2/15 | drivers: thermal: tsens: Simplify code flow in tsens_probedrivers/ | +3 | 0 replies | |
| 3/15 | drivers: thermal: tsens: Add __func__ identifier to debug statementsdrivers/ drivers/ | +7 | 1 reply | |
| 4/15 | drivers: thermal: tsens: Add debugfs supportdrivers/ drivers/ drivers/ | +91 | 0 replies | |
| 5/15 | arm: dts: msm8974: thermal: Add thermal zones for each sensorarch/ | +90 | 0 replies | |
| 6/15 | arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensorsarch/ | +2 | 0 replies | |
| 7/15 | dt-bindings: thermal: tsens: Convert over to a yaml schemaDocumentation/ Documentation/ MAINTAINERS | +169 | 0 replies | |
| 8/15 | arm64: dts: sdm845: thermal: Add interrupt supportarch/ | +4 | 0 replies | |
| 9/15 | arm64: dts: msm8996: thermal: Add interrupt supportarch/ | +4 | 0 replies | |
| 10/15 | arm64: dts: msm8998: thermal: Add interrupt supportarch/ | +4 | 0 replies | |
| 11/15 | arm64: dts: qcs404: thermal: Add interrupt supportarch/ | +2 | 0 replies | |
| 12/15 | arm: dts: msm8974: thermal: Add interrupt supportarch/ | +2 | 0 replies | |
| 13/15 | arm64: dts: msm8916: thermal: Add interrupt supportarch/ | +2 | 0 replies | |
| 14/15 | drivers: thermal: tsens: Create function to return sign-extended temperaturedrivers/ | +35 | 0 replies | |
| 15/15 | drivers: thermal: tsens: Add interrupt supportdrivers/ drivers/ drivers/ +3 more | +669 | 0 replies |
Reviews trailers per patch
10 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Stephen Boyd | Daniel Lezcano | Brian Masney | Rob Herring |
|---|---|---|---|---|
| 1/15 | R-b | R-b | ||
| 2/15 | R-b | R-b | ||
| 3/15 | R-b | R-b | ||
| 4/15 | R-b | |||
| 5/15 | R-b | T-b | ||
| 6/15 | R-b | R-b | ||
| 7/15 | R-b | |||
| 8/15 | R-b | |||
| 9/15 | ||||
| 10/15 | ||||
| 11/15 | ||||
| 12/15 | T-b | |||
| 13/15 | ||||
| 14/15 | R-b | |||
| 15/15 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v7 00/15] thermal: qcom: tsens: Add interrupt support
Daniel, only patch 15 needs to be changed in the tree being submitted to linux-next. But here is the entire series for completeness.
Hi Thermal and MSM maintainers,
I believe this series is now ready to be merged. The DT bindings and driver changes should go through the thermal tree and the changes to the DT files themselves should go through the MSM tree. There is no hard ordering dependency because we're adding a new property to the driver. It would help to soak in linux-next for a few weeks to catch anything on kernelci.org.
1-4, 7, 14, 15 => thermal tree
5, 6, 8-13 => msm tree (already applied by Andy)
Regards,
Amit
Changes since v6:
- Stephen reported a warning that only shows up with gcc 9.x
(https://lore.kernel.org/lkml/CAHLCerOkeOEEUgtJ=YgDKKXDiyFXHQ4LBdzg3-3VtKvpyceqFg@mail.gmail.com/). Include a patch to initialise the index variable to zero.
Changes since v5:
- Julia found a missing put_device() call in the success path of tsens_register() while baking in linux-next. A single line change to allow the error and success path to use the call to put_device(). Thanks Julia and LKP.
Changes since v4:
- Change to of-thermal core[1] to force interrupts w/o changing polling-delay DT parameter
- Corresponding changes to DT files to remove the hunks setting the values to 0
- Collected reviews and acks
Changes since v3:
- Fix up the YAML definitions based on Rob's review
Changes since v2:
- Addressed Stephen's review comment
- Moved the dt-bindings to yaml (This throws up some new warnings in various QCOM devicetrees. I'll send out a separate series to fix them up)
- Collected reviews and acks
- Added the dt-bindings to MAINTAINERS
Changes since v1:
- Collected reviews and acks
- Addressed Stephen's review comments (hopefully I got them all).
- Completely removed critical interrupt infrastructure from this series. Will post that separately.
- Fixed a bug in sign-extension of temperature.
- Fixed DT bindings to use the name of the interrupt e.g. "uplow" and use platform_get_irq_byname().
Add interrupt support to TSENS. The first 6 patches are general fixes and cleanups to the driver before interrupt support is introduced.
Amit Kucheria (15):
drivers: thermal: tsens: Get rid of id field in tsens_sensor
drivers: thermal: tsens: Simplify code flow in tsens_probe
drivers: thermal: tsens: Add __func__ identifier to debug statements
drivers: thermal: tsens: Add debugfs support
arm: dts: msm8974: thermal: Add thermal zones for each sensor
arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors
dt-bindings: thermal: tsens: Convert over to a yaml schema
arm64: dts: sdm845: thermal: Add interrupt support
arm64: dts: msm8996: thermal: Add interrupt support
arm64: dts: msm8998: thermal: Add interrupt support
arm64: dts: qcs404: thermal: Add interrupt support
arm: dts: msm8974: thermal: Add interrupt support
arm64: dts: msm8916: thermal: Add interrupt support
drivers: thermal: tsens: Create function to return sign-extended
temperature
drivers: thermal: tsens: Add interrupt support
.../bindings/thermal/qcom-tsens.txt | 55 -- .../bindings/thermal/qcom-tsens.yaml | 168 ++++++ MAINTAINERS | 1 + arch/arm/boot/dts/qcom-msm8974.dtsi | 92 +++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 6 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 + arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 +- arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 + arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 + drivers/thermal/qcom/tsens-8960.c | 4 +- drivers/thermal/qcom/tsens-common.c | 529 ++++++++++++++++-- drivers/thermal/qcom/tsens-v0_1.c | 11 + drivers/thermal/qcom/tsens-v1.c | 29 + drivers/thermal/qcom/tsens-v2.c | 13 + drivers/thermal/qcom/tsens.c | 59 +- drivers/thermal/qcom/tsens.h | 286 ++++++++-- 16 files changed, 1102 insertions(+), 167 deletions(-) delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.txt create mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
Signature · 1 line
2.17.1