drm/panel: jh057n00900: Move dsi init sequence to prepare
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 1 replyIn review
- v13 patches 3 repliesSuperseded
Changes in v2 from the cover letter
* As per review comments by Sam Ravnborg
* Ignore failures to disable the backlight in jh057n_disable()
* Add 'drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently'
* Collected Reviewed-By: Thanks Sam!
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | drm/panel: jh057n00900: Move panel DSI init to enable()drivers/ | +8 | 0 replies | |
| 2/4 | drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable()drivers/ | +3 | 0 replies | |
| 3/4 | drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()sdrivers/ | +4 | 0 replies | |
| 4/4 | drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistentlydrivers/ | +2 | 0 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Sam Ravnborg |
|---|---|
| 1/4 | R-b |
| 2/4 | |
| 3/4 | R-b |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] drm/panel: jh057n00900: Move dsi init sequence to prepare
If the panel is wrapped in a panel_bridge it gets prepar()ed before the upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks are not enabled yet). To avoid this move the panel's first DSI access to enable() so the upstream bridge can prepare the DSI host controller in it's pre_enable().
The second patch makes the disable() call symmetric to the above and the third one just eases debugging.
Changes from v1:
* As per review comments by Sam Ravnborg
* Ignore failures to disable the backlight in jh057n_disable()
* Add 'drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently'
* Collected Reviewed-By: Thanks Sam!
To: "Guido Günther" <[email protected]>,Purism Kernel Team <[email protected]>,Thierry Reding <[email protected]>,Sam Ravnborg <[email protected]>,David Airlie <[email protected]>,Daniel Vetter <[email protected]>,[email protected],[email protected]
Guido Günther (4):
drm/panel: jh057n00900: Move panel DSI init to enable() drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable() drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()s drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently
.../drm/panel/panel-rocktech-jh057n00900.c | 31 ++++++++++--------- 1 file changed, 17 insertions(+), 14 deletions(-)
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel