Skip to content

Enforce Shared State Signing when optionsset

Joshua Lock openembedded-core 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v1 RFC3 patches 2 repliesSuperseded

Changes in v2 from the cover letter

* removed spurious Python subclass class and handling of an error condition that couldn't occur

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sstate: fix log messagemeta/classes/sstate.bbclass+1 -10 replies
2/3classes/sstate: don't use unsigned sstate when verification enabledmeta/classes/sstate.bbclass+2 -10 replies
3/3classes/sstate: regenerate sstate when signing enabledmeta/classes/sstate.bbclass+12 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] Enforce Shared State Signing when optionsset

There are 2 surprising behaviours in the current shared state signing implementation which this pull request addresses:
1) when signature verification is enabled a failure to verify doesn't prevent the shared state object from being used. A warning is printed and the unsigned shared state object is used to accelerate the task.
2) when signing is enabled the taskhash doesn't change and any existing, unsigned, shared state objects will not be signed. This is particularly problematic when combined with 1.

Please review the following changes for suitability for inclusion. If you have any objections or suggestions for improvement, please respond to the patches. If you agree with the changes, please provide your Acked-by.

Changes since v1:
* removed spurious Python subclass class and handling of an error condition that couldn't occur

The following changes since commit 835f7eac0610325e906591cd81890bebe8627580:

meta/lib/oeqa: Test for bootimg-biosplusefi Source (2019-07-23 22:26:28 +0100)

are available in the Git repository at:

https://github.com/joshuagl/poky joshuagl/signed-sstate2
https://github.com/joshuagl/poky/tree/joshuagl/signed-sstate2

Joshua Lock (3):
sstate: fix log message
classes/sstate: don't use unsigned sstate when verification enabled classes/sstate: regenerate sstate when signing enabled

 meta/classes/sstate.bbclass | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)
Signature · 1 line
2.21.0