Skip to content

mptcp: implement retransmit infrastructure

Paolo Abeni mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/27 patches 4 repliesIn review
  2. v2 RFC posting 1/28 patches 5 repliesSuperseded
  3. v16 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- rebased on top of "mptcp: remove token_release"
- handle unacked sequence update collision with a loop, as suggested by Mat

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mptcp: move before/after64 into the header filenet/mptcp/protocol.c net/mptcp/protocol.h+7 -70 replies
2/7mptcp: update per unacked sequence on pkt receptionnet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h+42 -60 replies
3/7mptcp: queue data for mptcp level retransmissionnet/mptcp/protocol.c net/mptcp/protocol.h+143 -80 replies
4/7mptcp: introduce MPTCP retransmission timernet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h+105 -10 replies
5/7mptcp: implement memory accounting for mptcp rtx queuenet/mptcp/protocol.c+26 -40 replies
6/7mptcp: rework mptcp_sendmsg_frag to accept optional dfragnet/mptcp/protocol.c+79 -550 replies
7/7mptcp: implement and use MPTCP-level retransmissionnet/mptcp/protocol.c net/mptcp/protocol.h+90 -32 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [MPTCP] [PATCH v2 0/7] mptcp: implement retransmit infrastructure

The retransmission infrastructure is now functionally completed, and I don't observe anymore memleak/socket reference leak.

Still there are a few self-test failures I still have to investigate. I *think* we could merge this series even with such failure pending, and fix them later, _if_ there is agreement.

v1 -> v2
- rebased on top of "mptcp: remove token_release"
- handle unacked sequence update collision with a loop, as suggested by Mat

RFC v2 -> v1
- update msk una_seq in tcp_incoming_options() and drop old patch 3/8
- cleanup timer management
- cleanup dfrag management

Paolo Abeni (7):
mptcp: move before/after64 into the header file
mptcp: update per unacked sequence on pkt reception
mptcp: queue data for mptcp level retransmission
mptcp: introduce MPTCP retransmission timer
mptcp: implement memory accounting for mptcp rtx queue
mptcp: rework mptcp_sendmsg_frag to accept optional dfrag
mptcp: implement and use MPTCP-level retransmission

 net/mptcp/options.c  |  47 ++++-
 net/mptcp/protocol.c | 396 +++++++++++++++++++++++++++++++++++++++----
 net/mptcp/protocol.h |  41 +++++
 3 files changed, 446 insertions(+), 38 deletions(-)
Signature · 1 line
2.21.0