Skip to content

Fixes for various compiler warnings

Patrick Steinhardt linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Annotate unused fields with UNUSEDsupport/misc/xstat.c support/nfs/rpc_socket.c+4 -20 replies
2/6Use <fcntl.h> header instead of <sys/fcntl.h>support/export/xtab.c support/nfs/rmtab.c support/nfs/svc_socket.c +1 more+4 -40 replies
3/6Use <poll.h> header instead of <sys/poll.h>utils/gssd/svcgssd_main_loop.c utils/statd/sm-notify.c+2 -20 replies
4/6configure.ac: Add <sys/socket.h> header when checking sizeof(socklen_t)configure.ac+4 -10 replies
5/6nfsd_path: Include missing header for `struct stat`support/include/nfsd_path.h+2 -00 replies
6/6mountd: Use unsigned for filesystem type magic constantsutils/mountd/cache.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Fixes for various compiler warnings

Hi,

here's some assorted fixes for compiler warnings I'm seeing on my platform. Most warnings are probably due to using musl libc, but the fixes should be the correct thing to do regardless. With this patchset, I can now compile nfs-utils with -Werror just fine.

Regards
Patrick

Patrick Steinhardt (6):
Annotate unused fields with UNUSED
Use <fcntl.h> header instead of <sys/fcntl.h> Use <poll.h> header instead of <sys/poll.h> configure.ac: Add <sys/socket.h> header when checking
sizeof(socklen_t)
nfsd_path: Include missing header for struct stat
mountd: Use unsigned for filesystem type magic constants

 configure.ac                   | 5 ++++-
 support/export/xtab.c          | 2 +-
 support/include/nfsd_path.h    | 2 ++
 support/misc/xstat.c           | 3 ++-
 support/nfs/rmtab.c            | 2 +-
 support/nfs/rpc_socket.c       | 3 ++-
 support/nfs/svc_socket.c       | 2 +-
 support/nfs/xio.c              | 2 +-
 utils/gssd/svcgssd_main_loop.c | 2 +-
 utils/mountd/cache.c           | 4 ++--
 utils/statd/sm-notify.c        | 2 +-
 11 files changed, 18 insertions(+), 11 deletions(-)
Signature · 1 line
2.23.0