Skip to content

i3c: remove device if failed on pre_assign_dyn_addr()

Vitor Soares linux-devicetree linux-i3c lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesIn review
  2. v14 patches 21 repliesSuperseded

Changes in v2 from the cover letter

- Move out detach/free the i3c_dev_desc from pre_assign_dyn_addr()
- Change i3c_master_search_i3c_boardinfo(newdev) to i3c_master_init_i3c_dev_boardinfo(newdev)
- Add fixes, stable tags on patch 2
- Add a note for no guarantee of 'assigned-address' use

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5i3c: master: detach and free device if pre_assign_dyn_addr() failsdrivers/i3c/master.c+15 -76 replies
2/5i3c: master: make sure ->boardinfo is initialized in add_i3c_dev_locked()drivers/i3c/master.c+25 -20 replies
3/5dt-bindings: i3c: Make 'assigned-address' valid if static address == 0Documentation/devicetree/bindings/i3c/i3c.txt+10 -31 reply
4/5dt-bindings: i3c: add a note for no guarantee of 'assigned-address' useDocumentation/devicetree/bindings/i3c/i3c.txt+3 -11 reply
5/5i3c: master: dw: reattach device on first available location of address tabledrivers/i3c/master/dw-i3c-master.c+16 -00 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchBoris BrezillonRob Herring
1/5
2/5
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] i3c: remove device if failed on pre_assign_dyn_addr()

This patch series remove the devices that fail during pre_assign_dyn_addr() and were being sent on DEFSVLS command. With the change above, during the i3c_master_add_i3c_dev_locked() is necessary to check if the device has i3c_boardinfo and try to assign the i3c_dev_boardinfo->init_dyn_addr if there no oldev. This change will allow to describe in DT device with preferable dynamic address but without static address.

Change in v2:
- Move out detach/free the i3c_dev_desc from pre_assign_dyn_addr()
- Change i3c_master_search_i3c_boardinfo(newdev) to i3c_master_init_i3c_dev_boardinfo(newdev)
- Add fixes, stable tags on patch 2
- Add a note for no guarantee of 'assigned-address' use

Vitor Soares (5):
i3c: master: detach and free device if pre_assign_dyn_addr() fails
i3c: master: make sure ->boardinfo is initialized in

    add_i3c_dev_locked()

dt-bindings: i3c: make 'assigned-address' valid if static address == 0
dt-bindings: i3c: add a note for no guarantee of 'assigned-address' use
i3c: master: dw: reattach device on first available location of
address table

 Documentation/devicetree/bindings/i3c/i3c.txt | 15 ++++++--
 drivers/i3c/master.c                          | 49 ++++++++++++++++++++++-----
 drivers/i3c/master/dw-i3c-master.c            | 16 +++++++++
 3 files changed, 68 insertions(+), 12 deletions(-)
Signature · 1 line
2.7.4