Skip to content

objtool,perf: Use shared x86 insn decoder

Josh Poimboeuf lkml 1 version Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4objtool: Move x86 insn decoder to a common locationtools/arch/x86/include/asm/inat.h tools/arch/x86/include/asm/inat_types.h tools/arch/x86/include/asm/insn.h +9 more+12 -120 replies
2/4perf: Update .gitignore filetools/perf/.gitignore+3 -00 replies
3/4perf intel-pt: Remove inat.c from build dependency listtools/perf/util/intel-pt-decoder/Build+1 -10 replies
4/4perf intel-pt: Use shared x86 insn decodertools/perf/arch/x86/tests/insn-x86.c tools/perf/arch/x86/util/archinsn.c tools/perf/check-headers.sh +9 more+18 -26273 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPeter Zijlstra (Intel)Masami Hiramatsu
SeriesA-b R-b A-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] objtool,perf: Use shared x86 insn decoder

It's kind of silly that we have *three* identical copies of the x86 insn decoder in the kernel tree. Make it approximately 50% less silly by reducing that number to two.

Josh Poimboeuf (4):
objtool: Move x86 insn decoder to a common location
perf: Update .gitignore file
perf intel-pt: Remove inat.c from build dependency list perf intel-pt: Use shared x86 insn decoder

 .../{objtool => }/arch/x86/include/asm/inat.h |    0
 .../arch/x86/include/asm/inat_types.h         |    0
 .../{objtool => }/arch/x86/include/asm/insn.h |    0
 .../arch/x86/include/asm/orc_types.h          |    0
 tools/{objtool => }/arch/x86/lib/inat.c       |    0
 tools/{objtool => }/arch/x86/lib/insn.c       |    0
 .../arch/x86/lib/x86-opcode-map.txt           |    0
 .../arch/x86/tools/gen-insn-attr-x86.awk      |    0
 tools/objtool/Makefile                        |    4 +-
 tools/objtool/arch/x86/Build                  |    4 +-
 tools/objtool/arch/x86/decode.c               |    4 +-
 tools/objtool/sync-check.sh                   |   12 +-
 tools/perf/.gitignore                         |    3 +
 tools/perf/arch/x86/tests/insn-x86.c          |    2 +-
 tools/perf/arch/x86/util/archinsn.c           |    2 +-
 tools/perf/check-headers.sh                   |   11 +-
 tools/perf/util/intel-pt-decoder/Build        |   22 +-
 .../intel-pt-decoder/gen-insn-attr-x86.awk    |  392 ------
 tools/perf/util/intel-pt-decoder/inat.c       |   82 --
 tools/perf/util/intel-pt-decoder/inat.h       |  230 ----
 tools/perf/util/intel-pt-decoder/inat_types.h |   15 -
 tools/perf/util/intel-pt-decoder/insn.c       |  593 ---------
 tools/perf/util/intel-pt-decoder/insn.h       |  216 ----
 .../intel-pt-decoder/intel-pt-insn-decoder.c  |   10 +-
 .../util/intel-pt-decoder/x86-opcode-map.txt  | 1072 -----------------
 25 files changed, 34 insertions(+), 2640 deletions(-)
 rename tools/{objtool => }/arch/x86/include/asm/inat.h (100%)
 rename tools/{objtool => }/arch/x86/include/asm/inat_types.h (100%)
 rename tools/{objtool => }/arch/x86/include/asm/insn.h (100%)
 rename tools/{objtool => }/arch/x86/include/asm/orc_types.h (100%)
 rename tools/{objtool => }/arch/x86/lib/inat.c (100%)
 rename tools/{objtool => }/arch/x86/lib/insn.c (100%)
 rename tools/{objtool => }/arch/x86/lib/x86-opcode-map.txt (100%)
 rename tools/{objtool => }/arch/x86/tools/gen-insn-attr-x86.awk (100%)
 delete mode 100644 tools/perf/util/intel-pt-decoder/gen-insn-attr-x86.awk
 delete mode 100644 tools/perf/util/intel-pt-decoder/inat.c
 delete mode 100644 tools/perf/util/intel-pt-decoder/inat.h
 delete mode 100644 tools/perf/util/intel-pt-decoder/inat_types.h
 delete mode 100644 tools/perf/util/intel-pt-decoder/insn.c
 delete mode 100644 tools/perf/util/intel-pt-decoder/insn.h
 delete mode 100644 tools/perf/util/intel-pt-decoder/x86-opcode-map.txt
Signature · 1 line
2.20.1