Skip to content

Fix more AsciiDoc/tor differences

Martin Ågren git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Documentation: wrap blocks with "--"Documentation/git-commit.txt Documentation/git-status.txt+16 -100 replies
2/7git-merge-base.txt: render indentations correctly under AsciidoctorDocumentation/git-merge-base.txt+57 -410 replies
3/7Documentation: wrap config listings in "----"Documentation/config.txt Documentation/git-config.txt Documentation/git-send-email.txt +1 more+87 -800 replies
4/7git-ls-remote.txt: wrap shell listing in "----"Documentation/git-ls-remote.txt+17 -150 replies
5/7git-receive-pack.txt: wrap shell [script] listing in "----"Documentation/git-receive-pack.txt+28 -240 replies
6/7git-merge-index.txt: wrap shell listing in "----"Documentation/git-merge-index.txt+15 -110 replies
7/7gitweb.conf.txt: switch pluses to backticks to help AsciidoctorDocumentation/gitweb.conf.txt+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] Fix more AsciiDoc/tor differences

This series roughly halves the line count of ./doc-diff --from-asciidoc --to-asciidoctor --cut-header-footer HEAD HEAD. Together with my recent (independent) mini-series [1], I claim that Asciidoctor 1.5.5 now processes the manpages better than AsciiDoc 8.6.10 does.

Patch 6/7 actually changes the rendering with both engines, so that they look nice and the same. The other patches are all no-ops with one engine while fixing things with the other -- they all improve the situation with Asciidoctor (which is what I care most about) except patch 1/7 which goes the other way (it reduces the doc-diff, which helps).

Patch 7/7 has an element of black magic to it. I wouldn't be too surprised if I've managed to appease my particular versions of these tools while not fixing -- or maybe even breaking? -- some other versions [that people actually use]. That's where I think a quick test would be the most valuable.

I've based this on maint on the assumption that these are bugfixes. (I know I've been bad on basing similar work off of maint.) This causes a conflict with master and pu in config.txt, which has learned about "includeIf onbranch:foo-branch" in the meantime. Maybe I've made the wrong call here -- Junio, if you'd rather have me submit this on master, just let me know.

[1] https://public-inbox.org/git/[email protected]/

Martin Ågren (7):
Documentation: wrap blocks with "--"
git-merge-base.txt: render indentations correctly under Asciidoctor
Documentation: wrap config listings in "----" git-ls-remote.txt: wrap shell listing in "----" git-receive-pack.txt: wrap shell [script] listing in "----" git-merge-index.txt: wrap shell listing in "----" gitweb.conf.txt: switch pluses to backticks to help Asciidoctor

 Documentation/config.txt           | 84 ++++++++++++-------------
 Documentation/git-commit.txt       |  8 ++-
 Documentation/git-config.txt       | 56 +++++++++--------
 Documentation/git-ls-remote.txt    | 32 +++++-----
 Documentation/git-merge-base.txt   | 98 +++++++++++++++++-------------
 Documentation/git-merge-index.txt  | 26 ++++----
 Documentation/git-receive-pack.txt | 52 ++++++++--------
 Documentation/git-send-email.txt   | 12 ++--
 Documentation/git-status.txt       | 18 +++---
 Documentation/gitmodules.txt       | 15 ++---
 Documentation/gitweb.conf.txt      |  6 +-
 11 files changed, 223 insertions(+), 184 deletions(-)
Signature · 1 line
2.23.0