Skip to content

net/cxgbe: bug fixes and updates for CXGBE/CXGBEVF PMD

Rahul Lakkireddy dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 1 replyIn review
  2. v112 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Remove rarely used compile time enabled debug logs from datapath in patch 7.
- In cxgbe.rst doc, use ^ (instead of -) to represent common and vf-only devargs as subsection of Runtime Options in patch 8.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12net/cxgbe: add cxgbe_ prefix to global functionsdrivers/net/cxgbe/cxgbe_filter.c drivers/net/cxgbe/cxgbe_filter.h drivers/net/cxgbe/cxgbe_flow.c +3 more+37 -340 replies
2/12net/cxgbe: fix NULL access when allocating CLIP entrydrivers/net/cxgbe/cxgbe_filter.c+1 -10 replies
3/12net/cxgbe: fix slot allocation for IPv6 flowsdrivers/net/cxgbe/cxgbe_filter.c drivers/net/cxgbe/cxgbe_filter.h drivers/net/cxgbe/cxgbe_flow.c+85 -1280 replies
4/12net/cxgbe: fix parsing VLAN ID rewrite actiondrivers/net/cxgbe/cxgbe_flow.c+12 -30 replies
5/12net/cxgbe: fix prefetch for non-coalesced Tx packetsdrivers/net/cxgbe/cxgbe_ethdev.c drivers/net/cxgbe/sge.c+7 -30 replies
6/12net/cxgbe: avoid polling link status before device startdrivers/net/cxgbe/cxgbe_ethdev.c+9 -00 replies
7/12net/cxgbe: use dynamic logging for debug printsconfig/common_base doc/guides/nics/cxgbe.rst drivers/net/cxgbe/base/adapter.h +2 more+19 -910 replies
8/12net/cxgbe: separate VF only devargsdoc/guides/nics/cxgbe.rst drivers/net/cxgbe/base/adapter.h drivers/net/cxgbe/cxgbe.h +3 more+76 -320 replies
9/12net/cxgbe: add devarg to control Tx coalescingconfig/common_base doc/guides/nics/cxgbe.rst drivers/net/cxgbe/base/adapter.h +5 more+25 -160 replies
10/12net/cxgbe: fetch max Tx coalesce limit from firmwaredoc/guides/nics/cxgbe.rst drivers/net/cxgbe/base/common.h drivers/net/cxgbe/base/t4fw_interface.h +4 more+52 -350 replies
11/12net/cxgbe: add rte_flow support for matching VLANdrivers/net/cxgbe/base/t4_regs_values.h drivers/net/cxgbe/cxgbe_filter.c drivers/net/cxgbe/cxgbe_flow.c +1 more+162 -130 replies
12/12net/cxgbe: add rte_flow support for setting VLAN PCPdrivers/net/cxgbe/cxgbe_flow.c+27 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 00/12] net/cxgbe: bug fixes and updates for CXGBE/CXGBEVF PMD

This series of patches contain bug fixes and feature updates for CXGBE and CXGBEVF PMD. Patches 1 to 6 contain bug fixes. Patches 7 to 12 contain updates and new features for CXGBE/CXGBEVF PMD.

Patch 1 adds cxgbe_ prefix to some global functions to avoid name collision.

Patch 2 fixes NULL dereference when allocating CLIP for IPv6 rte_flow offloads.

Patch 3 fixes slot allocation logic for IPv6 rte_flow offloads for T6 NICs.

Patch 4 fixes issues with parsing VLAN rte_flow offload actions.

Patch 5 prefetches packets for non-coalesced Tx packets.

Patch 6 fixes NULL dereference when accessing firmware event queue for link updates before it is created.

Patch 7 reworks compilation dependent logs to use dynamic logging.

Patch 8 reworks devargs parsing to separate CXGBE VF only arguments.

Patch 9 removes compilation dependent flag that controls Tx coalescing throughput vs latency behavior and uses devargs instead.

Patch 10 uses new firmware API to fetch the maximum number of packets that can be coalesced in Tx path.

Patch 11 adds support for VLAN pattern match item via rte_flow offload.

Patch 12 adds support for setting VLAN PCP action item via rte_flow offload.

Thanks,
Rahul

---
v2:
- Remove rarely used compile time enabled debug logs from datapath in patch 7.
- In cxgbe.rst doc, use ^ (instead of -) to represent common and vf-only devargs as subsection of Runtime Options in patch 8.

Rahul Lakkireddy (12):
net/cxgbe: add cxgbe_ prefix to global functions net/cxgbe: fix NULL access when allocating CLIP entry net/cxgbe: fix slot allocation for IPv6 flows net/cxgbe: fix parsing VLAN ID rewrite action net/cxgbe: fix prefetch for non-coalesced Tx packets net/cxgbe: avoid polling link status before device start net/cxgbe: use dynamic logging for debug prints net/cxgbe: separate VF only devargs
net/cxgbe: add devarg to control Tx coalescing net/cxgbe: fetch max Tx coalesce limit from firmware net/cxgbe: add rte_flow support for matching VLAN net/cxgbe: add rte_flow support for setting VLAN PCP

 config/common_base                      |   6 -
 doc/guides/nics/cxgbe.rst               |  57 +++---
 drivers/net/cxgbe/base/adapter.h        |  27 ++-
 drivers/net/cxgbe/base/common.h         |   1 +
 drivers/net/cxgbe/base/t4_regs_values.h |   9 +
 drivers/net/cxgbe/base/t4fw_interface.h |   3 +-
 drivers/net/cxgbe/cxgbe.h               |  10 +-
 drivers/net/cxgbe/cxgbe_compat.h        |  55 ++----
 drivers/net/cxgbe/cxgbe_ethdev.c        |  35 ++--
 drivers/net/cxgbe/cxgbe_filter.c        | 230 ++++++++++--------------
 drivers/net/cxgbe/cxgbe_filter.h        |  22 +--
 drivers/net/cxgbe/cxgbe_flow.c          | 204 +++++++++++++++++++--
 drivers/net/cxgbe/cxgbe_main.c          | 137 +++++++-------
 drivers/net/cxgbe/cxgbe_pfvf.h          |  10 ++
 drivers/net/cxgbe/cxgbevf_ethdev.c      |   7 +
 drivers/net/cxgbe/cxgbevf_main.c        |  12 +-
 drivers/net/cxgbe/l2t.c                 |   3 +-
 drivers/net/cxgbe/l2t.h                 |   3 +-
 drivers/net/cxgbe/sge.c                 |  21 +--
 19 files changed, 504 insertions(+), 348 deletions(-)
Signature · 1 line
2.18.0