Skip to content

Speed up SPI simplex transfers on Raspberry Pi

Lukas Wunner linux-spi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest10 patches 7 repliesIn review

Changes since v2 from the cover letter

* Patch [03/10]: Round up struct spi_controller to cacheline size instead of putting it behind the driver-private data. (Mark Brown)

* Move patch "spi: bcm2835: Work around DONE bit erratum" to the front of the series to ease backporting to stable. (Mark Brown) (I don't think it's necessary to backport it, hence it's not marked for stable, but it might be autoselected by Sasha Levin's AI.)

* Add all collected Acked-by and Tested-by tags, rebase on for-5.4.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10dmaengine: bcm2835: Allow reusable descriptorsdrivers/dma/bcm2835-dma.c+1 -00 replies
2/10dmaengine: bcm2835: Allow cyclic transactions without interruptdrivers/dma/bcm2835-dma.c+10 -20 replies
3/10spi: Guarantee cacheline alignment of driver-private datadrivers/spi/spi.c+7 -41 reply
4/10spi: bcm2835: Work around DONE bit erratumdrivers/spi/spi-bcm2835.c+12 -21 reply
5/10spi: bcm2835: Drop dma_pending flagdrivers/spi/spi-bcm2835.c+8 -153 replies
6/10spi: bcm2835: Cache CS register value for ->prepare_message()drivers/spi/spi-bcm2835.c+26 -200 replies
7/10spi: bcm2835: Speed up TX-only DMA transfers by clearing RX FIFOdrivers/spi/spi-bcm2835.c+218 -230 replies
8/10dmaengine: bcm2835: Document struct bcm2835_dmadevdrivers/dma/bcm2835-dma.c+6 -00 replies
9/10dmaengine: bcm2835: Avoid accessing memory when copying zeroesdrivers/dma/bcm2835-dma.c+19 -00 replies
10/10spi: bcm2835: Speed up RX-only DMA transfers by zero-filling TX FIFOdrivers/spi/spi-bcm2835.c+82 -110 replies

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchNuno SáNoralf TrønnesStefan WahrenMartin SperlVinod Koul
1/10T-b T-b A-b A-b A-b
2/10T-b T-b A-b A-b A-b
3/10
4/10T-b T-b A-b A-b
5/10T-b T-b A-b A-b
6/10T-b T-b A-b A-b
7/10T-b T-b A-b A-b
8/10T-b T-b A-b A-b A-b
9/10T-b T-b A-b A-b A-b
10/10T-b T-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/10] Speed up SPI simplex transfers on Raspberry Pi

Extend the BCM2835 SPI driver to handle simplex transfers internally, thereby reducing their latency and CPU usage and obviating the need to have the SPI core convert to full-duplex via SPI_CONTROLLER_MUST_TX/RX.

Changes since v2:

* Patch [03/10]: Round up struct spi_controller to cacheline size instead of putting it behind the driver-private data. (Mark Brown)

* Move patch "spi: bcm2835: Work around DONE bit erratum" to the front of the series to ease backporting to stable. (Mark Brown) (I don't think it's necessary to backport it, hence it's not marked for stable, but it might be autoselected by Sasha Levin's AI.)

* Add all collected Acked-by and Tested-by tags, rebase on for-5.4.

Link to v1:

https://lore.kernel.org/dmaengine/[email protected]/T/#t

Lukas Wunner (10):
dmaengine: bcm2835: Allow reusable descriptors
dmaengine: bcm2835: Allow cyclic transactions without interrupt
spi: Guarantee cacheline alignment of driver-private data
spi: bcm2835: Work around DONE bit erratum
spi: bcm2835: Drop dma_pending flag
spi: bcm2835: Cache CS register value for ->prepare_message()
spi: bcm2835: Speed up TX-only DMA transfers by clearing RX FIFO
dmaengine: bcm2835: Document struct bcm2835_dmadev
dmaengine: bcm2835: Avoid accessing memory when copying zeroes
spi: bcm2835: Speed up RX-only DMA transfers by zero-filling TX FIFO

 drivers/dma/bcm2835-dma.c |  38 +++-
 drivers/spi/spi-bcm2835.c | 407 +++++++++++++++++++++++++++++++-------
 drivers/spi/spi.c         |  11 +-
 3 files changed, 384 insertions(+), 72 deletions(-)
Signature · 1 line
2.23.0