Skip to content

completion: teach rebase and archive to use __gitcomp_builtin

Denton Liu git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2completion: teach rebase to use __gitcomp_builtincontrib/completion/git-completion.bash+7 -150 replies
2/2completion: teach archive to use __gitcomp_builtincontrib/completion/git-completion.bash+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] completion: teach rebase and archive to use __gitcomp_builtin

Currently, the completion function for rebase and archive don't take advantage of __gitcomp_builtin(). Teach them to use it so that future changes to options will automatically be included by the completion script with no extra work.

I discovered rebase wasn't using it and fixed that and I started looking for other low-hanging fruit to fix. I deliberately left stuff like diff and log alone since that's a whole Pandora's box that I don't really want to open right now.

Denton Liu (2):
completion: teach rebase to use __gitcomp_builtin
completion: teach archive to use __gitcomp_builtin

 contrib/completion/git-completion.bash | 27 ++++++++------------------
 1 file changed, 8 insertions(+), 19 deletions(-)
Signature · 1 line
2.23.0.37.g745f681289