Skip to content

leds: lm3692x: Probing and flag fixes

Guido Günther linux-leds lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesIn review
  2. v25 patches 3 repliesSuperseded
  3. v15 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Add Acked-by from Pavel Machek, thanks!
https://lore.kernel.org/linux-leds/20190920114743.GA21835@amd/
- As per review comment from Dan Murphy
https://lore.kernel.org/linux-leds/[email protected]/
- rename return value from ret2 to reg_ret
- print error code

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5leds: lm3692x: Print error value on dev_errdrivers/leds/leds-lm3692x.c+10 -70 replies
2/5leds: lm3692x: Don't overwrite return value in error pathdrivers/leds/leds-lm3692x.c+5 -41 reply
3/5leds: lm3692x: Handle failure to probe the regulatordrivers/leds/leds-lm3692x.c+11 -21 reply
4/5leds: lm3692x: Use flags from LM3692X_BOOST_CTRLdrivers/leds/leds-lm3692x.c+3 -30 replies
5/5leds: lm3692x: Use flags from LM3692X_BRT_CTRLdrivers/leds/leds-lm3692x.c+1 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPavel MachekDan Murphy
1/5A-b R-b
2/5A-b R-b
3/5A-b R-b
4/5A-b R-b
5/5A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] leds: lm3692x: Probing and flag fixes

The driver currently returns success on init although probing fails and register setup uses flag values from other registers which is confusing when reading the driver. This series cleans this up.

Changes from v2:
- Add Acked-by from Pavel Machek, thanks!
https://lore.kernel.org/linux-leds/20190920114743.GA21835@amd/
- As per review comment from Dan Murphy
https://lore.kernel.org/linux-leds/[email protected]/
- rename return value from ret2 to reg_ret
- print error code

Changes from v1:
- Add reviewed by's from Dan Murphy, thanks!
https://lore.kernel.org/linux-leds/[email protected]/T/#mc183f3f65931371fa9f9ca2e0e83e0b85010f24b
https://lore.kernel.org/linux-leds/[email protected]/T/#mb845fac36327a5d5dd03fe7e988eef0eb5626f82
https://lore.kernel.org/linux-leds/[email protected]/T/#m995bce73dda3e3bd4f0c2e8f98cbd04a39c13832
- As per review comment from Dan Murphy
- Don't drop error message when disabling the regulator fails

    https://lore.kernel.org/linux-leds/[email protected]/T/#m2ab6dc33b7277b71a197c3747847f1c4d9d9c1d8
  - Handle -ENODEV (when the regulator is not set)
    https://lore.kernel.org/linux-leds/[email protected]/T/#mf6212c29bbfa37b43200ea2c9744074de4f068ee

- Add Acked-by from Pavel Machek, thanks!
https://lore.kernel.org/linux-leds/20190919095415.GA29939@amd/

Guido Günther (5):
leds: lm3692x: Print error value on dev_err
leds: lm3692x: Don't overwrite return value in error path
leds: lm3692x: Handle failure to probe the regulator
leds: lm3692x: Use flags from LM3692X_BOOST_CTRL
leds: lm3692x: Use flags from LM3692X_BRT_CTRL

 drivers/leds/leds-lm3692x.c | 47 +++++++++++++++++++++++--------------
 1 file changed, 30 insertions(+), 17 deletions(-)
Signature · 1 line
2.23.0.rc1