Skip to content

DSC MST support for DRM and AMDGPU

[email protected] amd-gfx dri-devel 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest posting 2/212 of 17 patches 5 repliesIn review
  2. v4 posting 2/29 of 13 patches 4 repliesSuperseded
  3. v3 posting 2/27 of 13 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v7 posting 1/21 patch3 repliesSuperseded
v51 patch2 repliesSuperseded
v4 posting 1/21 patch1 replySuperseded
v3 posting 1/21 patch0 repliesSuperseded
v210 of 14 patches7 repliesSuperseded
v111 of 15 patches6 repliesSuperseded

12 of 17 patches are in this archive. The cover letter announces 17.

Patches in v7 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/17drm/dp_mst: Parse FEC capability on MST portsdrivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+5 -00 replies
3/17drm/dp_mst: Add MST support to DP DPCD R/W functionsdrivers/gpu/drm/drm_dp_aux_dev.c drivers/gpu/drm/drm_dp_helper.c+23 -200 replies
4/17drm/dp_mst: Fill branch->num_portsdrivers/gpu/drm/drm_dp_mst_topology.c+2 -00 replies
6/17drm/dp_mst: Add new quirk for Synaptics MST hubsdrivers/gpu/drm/drm_dp_helper.c drivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_helper.h+36 -00 replies
7/17drm/amd/display: Initialize DSC PPS variables to 0drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c+6 -00 replies
8/17drm/amd/display: Validate DSC caps on MST endpointsdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c+29 -10 replies
9/17drm/amd/display: Write DSC enable to MST DPCDdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c+18 -10 replies
10/17drm/dp_mst: Manually overwrite PBN divider for calculating timeslotsdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/drm_dp_mst_topology.c drivers/gpu/drm/i915/display/intel_dp_mst.c +2 more+14 -61 reply
11/17drm/dp_mst: Add DSC enablement helpers to DRMdrivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+66 -03 replies
12/17drm/dp_mst: Add branch bandwidth validation to MST atomic checkdrivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+66 -21 reply
13/17drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCsdrivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+92 -00 replies
14/17drm/amd/display: Add PBN per slot calculation for DSCdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h+10 -00 replies

Reviews trailers per patch

8 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchManasi NavareLyude PaulHarry WentlandWenjing LiuNicholas KazlauskasLeo Li
SeriesR-b R-b R-b R-b R-b R-b
2/17R-b R-b
3/17R-b R-b
4/17R-b R-b
6/17R-b R-b
7/17R-b
8/17R-b
9/17R-b
10/17R-b
11/17
12/17
13/17
14/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/17] DSC MST support for DRM and AMDGPU

From: Mikita Lipski <[email protected]>

Patches are based of amd-staging-drm-next, the follow up set of patches will be sent for drm-tip

This set of patches is a continuation of DSC enablement patches for AMDGPU. This set enables DSC on MST. It also contains implementation of both encoder and connector atomic check routines.

These patches have been introduced in multiple iterations to the mailing list before. These patches were developed by David Francis as part of his work on DSC.

v2: squashed previously 3 separate atomic check patches, separate atomic check for dsc connectors, track vcpi and pbn on connectors.

v3: Moved modeset trigger on affected MST displays to DRM

v4: Fix warnings, use current mode's bpc rather than display's maximum capable one

v5: Moving branch's bandwidth validation to DRM, Added function to enable DSC per port in DRM

v6: Compute fair share uses DRM helper for BW validation

v7: Add helper to overwrite PBN divider per slot,
Add helper function to trigger modeset on affected DSC connectors
in DRM

David Francis (9):
drm/dp_mst: Add PBN calculation for DSC modes drm/dp_mst: Parse FEC capability on MST ports drm/dp_mst: Add MST support to DP DPCD R/W functions drm/dp_mst: Fill branch->num_ports
drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux drm/amd/display: Initialize DSC PPS variables to 0 drm/amd/display: Validate DSC caps on MST endpoints drm/amd/display: Write DSC enable to MST DPCD drm/amd/display: MST DSC compute fair share drm/dp_mst: Add new quirk for Synaptics MST hubs

Mikita Lipski (8):
drm/dp_mst: Manually overwrite PBN divider for calculating timeslots drm/dp_mst: Add DSC enablement helpers to DRM
drm/dp_mst: Add branch bandwidth validation to MST atomic check drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs drm/amd/display: Add PBN per slot calculation for DSC drm/amd/display: Recalculate VCPI slots for new DSC connectors drm/amd/display: Trigger modesets on MST DSC connectors

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 117 ++++-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |   1 +
 .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c |  19 +-
 .../display/amdgpu_dm/amdgpu_dm_mst_types.c   | 395 ++++++++++++++++-
 .../display/amdgpu_dm/amdgpu_dm_mst_types.h   |   5 +
 .../drm/amd/display/dc/core/dc_link_hwss.c    |   3 +
 .../gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c  |   3 +
 .../drm/amd/display/dc/dcn20/dcn20_resource.c |   7 +-
 .../drm/amd/display/dc/dcn20/dcn20_resource.h |   1 +
 drivers/gpu/drm/drm_dp_aux_dev.c              |  12 +-
 drivers/gpu/drm/drm_dp_helper.c               |  33 +-
 drivers/gpu/drm/drm_dp_mst_topology.c         | 401 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   5 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |   6 +-
 drivers/gpu/drm/radeon/radeon_dp_mst.c        |   2 +-
 include/drm/drm_dp_helper.h                   |   7 +
 include/drm/drm_dp_mst_helper.h               |  19 +-
 17 files changed, 989 insertions(+), 47 deletions(-)
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx