Skip to content

Add advanced features for Huawei hinic pmd

Xiaoyun wang dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest19 patches 7 repliesIn review
  2. v319 patches 6 repliesSuperseded
  3. v217 patches 13 repliesSuperseded

Changes in v4 from the cover letter

- Fix receive performance code review comments
- Fix 32-bit build errs for mbox logs
- Modify skb description as mbuf

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19net/hinic/base: add mbox command channel for SRIOVdoc/guides/nics/features/hinic.ini doc/guides/nics/hinic.rst drivers/net/hinic/Makefile +5 more+1070 -52 replies
2/19net/hinic/base: add HW interfaces for SR-IOVdrivers/net/hinic/base/hinic_compat.h drivers/net/hinic/base/hinic_pmd_api_cmd.c drivers/net/hinic/base/hinic_pmd_cfg.c +11 more+616 -2240 replies
3/19net/hinic: add VF PMD operation interfacesdrivers/net/hinic/base/hinic_pmd_niccfg.c drivers/net/hinic/base/hinic_pmd_niccfg.h drivers/net/hinic/hinic_pmd_ethdev.c+223 -810 replies
4/19net/hinic: add VLAN filter and offloaddoc/guides/nics/features/hinic.ini doc/guides/nics/hinic.rst drivers/net/hinic/base/hinic_pmd_cmd.h +4 more+372 -60 replies
5/19net/hinic: add allmulticast mode and MTU setdoc/guides/nics/features/hinic.ini doc/guides/nics/hinic.rst drivers/net/hinic/hinic_pmd_ethdev.c +1 more+114 -50 replies
6/19net/hinic: add unicast and multicast MAC setdoc/guides/nics/hinic.rst drivers/net/hinic/base/hinic_pmd_niccfg.c drivers/net/hinic/hinic_pmd_ethdev.c +1 more+298 -210 replies
7/19net/hinic/base: add fdir config interfacedoc/guides/nics/features/hinic.ini doc/guides/nics/hinic.rst drivers/net/hinic/base/hinic_pmd_cmd.h +2 more+343 -00 replies
8/19net/hinic: add fdir validate flow operationsdrivers/net/hinic/Makefile drivers/net/hinic/hinic_pmd_ethdev.c drivers/net/hinic/hinic_pmd_ethdev.h +2 more+1240 -00 replies
9/19net/hinic: create and destroy ntuple filterdrivers/net/hinic/hinic_pmd_ethdev.h drivers/net/hinic/hinic_pmd_flow.c+759 -00 replies
10/19net/hinic: create and destroy fdir filterdrivers/net/hinic/hinic_pmd_ethdev.h drivers/net/hinic/hinic_pmd_flow.c+422 -170 replies
11/19net/hinic: flush fdir filterdrivers/net/hinic/hinic_pmd_ethdev.c drivers/net/hinic/hinic_pmd_ethdev.h drivers/net/hinic/hinic_pmd_flow.c+158 -10 replies
12/19net/hinic: set link down and updoc/guides/nics/hinic.rst drivers/net/hinic/base/hinic_pmd_cmd.h drivers/net/hinic/base/hinic_pmd_niccfg.c +2 more+112 -00 replies
13/19net/hinic: get firmware versiondoc/guides/nics/features/hinic.ini doc/guides/nics/hinic.rst drivers/net/hinic/base/hinic_pmd_cmd.h +3 more+80 -00 replies
14/19net/hinic: support inner L3 checksum offloaddrivers/net/hinic/hinic_pmd_ethdev.c drivers/net/hinic/hinic_pmd_ethdev.h drivers/net/hinic/hinic_pmd_rx.c +3 more+146 -970 replies
15/19net/hinic: support LRO offloaddoc/guides/nics/features/hinic.ini doc/guides/nics/hinic.rst drivers/net/hinic/hinic_pmd_ethdev.c+20 -60 replies
16/19net/hinic: add hinic PMD doc filesdoc/guides/nics/features/hinic.ini doc/guides/rel_notes/release_19_11.rst+11 -02 replies
17/19net/hinic/base: optimize aeq interfacesdrivers/net/hinic/base/hinic_csr.h drivers/net/hinic/base/hinic_pmd_cmd.h drivers/net/hinic/base/hinic_pmd_eqs.c +1 more+67 -2170 replies
18/19net/hinic: optimize RX performancedrivers/net/hinic/hinic_pmd_rx.c drivers/net/hinic/hinic_pmd_rx.h+2 -50 replies
19/19net/hinic: add support for getting rxq or txq infodrivers/net/hinic/hinic_pmd_ethdev.c+34 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [dpdk-dev] [PATCH v4 00/19] Add advanced features for Huawei hinic pmd

This patch set adds advanced features for Huawei hinic pmd, such as VLAN filter and VLAN offload, SR-IOV, FW version get, set link down and up, Flow director for LACP, VRRP, BGP and so on.

--
v2:
- Fix RSS bugs for vxlan packets inner type
- Add comments for new added func interface
- Fix code review comments from patch v1
- Fix code style problems
- Remove ceq interfaces and definitions that not used
- Fix aeq init bugs, firstly alloc aeq resource, then set aeq ctrl len
- Fix bar map bugs for VF Page size larger than PF
- Modify link state set, add enable or disable fiber in tx direction
- Fix mbox and mgmt channel sync lock mechanism to reduce CPU usage
- Fix FDIR bugs for VRRP packets
- Fit ABI changes from dpdk lib

v3:
- Split hinic.ini and hinic.rst to related feature patches
- Add min_mtu & max_mtu initialization for hinic_dev_infos_get
- Fix fdir config patch with net/hinic/base
- Split link patch into link and fw version getting 2 patches
- Update pmd doc files to new next version
- Add comments for cover letter patch
- Add rxq & txq info getting interfaces
- Fix load intrinsics for receiving packets

v4:
- Fix receive performance code review comments
- Fix 32-bit build errs for mbox logs
- Modify skb description as mbuf

Xiaoyun wang (19):
net/hinic/base: add mbox command channel for SRIOV net/hinic/base: add HW interfaces for SR-IOV net/hinic: add VF PMD operation interfaces net/hinic: add VLAN filter and offload net/hinic: add allmulticast mode and MTU set net/hinic: add unicast and multicast MAC set net/hinic/base: add fdir config interface net/hinic: add fdir validate flow operations net/hinic: create and destroy ntuple filter net/hinic: create and destroy fdir filter net/hinic: flush fdir filter
net/hinic: set link down and up
net/hinic: get firmware version
net/hinic: support inner L3 checksum offload net/hinic: support LRO offload
net/hinic: add hinic PMD doc files net/hinic/base: optimize aeq interfaces net/hinic: optimize RX performance net/hinic: add support for getting rxq or txq info

 doc/guides/nics/features/hinic.ini         |   12 +-
 doc/guides/nics/hinic.rst                  |   10 +
 doc/guides/rel_notes/release_19_11.rst     |    9 +
 drivers/net/hinic/Makefile                 |    2 +
 drivers/net/hinic/base/hinic_compat.h      |   68 +-
 drivers/net/hinic/base/hinic_csr.h         |   29 +-
 drivers/net/hinic/base/hinic_pmd_api_cmd.c |   60 +-
 drivers/net/hinic/base/hinic_pmd_cfg.c     |   35 +
 drivers/net/hinic/base/hinic_pmd_cmd.h     |   26 +-
 drivers/net/hinic/base/hinic_pmd_eqs.c     |  245 +--
 drivers/net/hinic/base/hinic_pmd_eqs.h     |    5 +-
 drivers/net/hinic/base/hinic_pmd_hwdev.c   |  214 ++-
 drivers/net/hinic/base/hinic_pmd_hwdev.h   |   11 +-
 drivers/net/hinic/base/hinic_pmd_hwif.c    |   85 +-
 drivers/net/hinic/base/hinic_pmd_hwif.h    |   15 +-
 drivers/net/hinic/base/hinic_pmd_mbox.c    |  937 +++++++++++
 drivers/net/hinic/base/hinic_pmd_mbox.h    |   93 ++
 drivers/net/hinic/base/hinic_pmd_mgmt.c    |   83 +-
 drivers/net/hinic/base/hinic_pmd_mgmt.h    |    2 +-
 drivers/net/hinic/base/hinic_pmd_niccfg.c  |  777 ++++++++-
 drivers/net/hinic/base/hinic_pmd_niccfg.h  |  203 +++
 drivers/net/hinic/base/hinic_pmd_nicio.c   |   15 +-
 drivers/net/hinic/base/hinic_pmd_nicio.h   |    3 +-
 drivers/net/hinic/base/meson.build         |    1 +
 drivers/net/hinic/hinic_pmd_ethdev.c       | 1026 ++++++++++--
 drivers/net/hinic/hinic_pmd_ethdev.h       |  139 +-
 drivers/net/hinic/hinic_pmd_flow.c         | 2385 ++++++++++++++++++++++++++++
 drivers/net/hinic/hinic_pmd_rx.c           |   34 +-
 drivers/net/hinic/hinic_pmd_rx.h           |    4 +-
 drivers/net/hinic/hinic_pmd_tx.c           |  203 ++-
 drivers/net/hinic/hinic_pmd_tx.h           |    2 +-
 drivers/net/hinic/meson.build              |    1 +
 32 files changed, 6068 insertions(+), 666 deletions(-)
 create mode 100644 drivers/net/hinic/base/hinic_pmd_mbox.c
 create mode 100644 drivers/net/hinic/base/hinic_pmd_mbox.h
 create mode 100644 drivers/net/hinic/hinic_pmd_flow.c
Signature · 1 line
1.8.3.1