Code of Conduct + Extra Guides and Best Practices + VOTE
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest7 patches 11 repliesIn review
- v37 patches 8 repliesSuperseded
- v26 patches 35 repliesSuperseded
Changes in v4 from the cover letter
* More typo and whitespace fixes
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | Import v1.4 of Contributor Covenant CoCcode-of-conduct.md | +76 | 0 replies | |
| 2/7 | Xen Project Code of Conductcode-of-conduct.md | +28 | 0 replies | |
| 3/7 | Reformat Xen Project CoC to fit into 80 character limitcode-of-conduct.md | +33 | 0 replies | |
| 4/7 | Add Communication Guidecode-of-conduct.md communication-guide.md | +69 | 1 reply | |
| 5/7 | Add Code Review Guidecode-review-guide.md | +313 | 1 reply | |
| 6/7 | Add guide on Communication Best Practicecommunication-practice.md | +504 | 6 replies | |
| 7/7 | Added Resolving Disagreementresolving-disagreement.md | +188 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [Xen-devel] [PATCH v4 0/7] Code of Conduct + Extra Guides and Best Practices + VOTE
From: Lars Kurth <[email protected]>
This series proposes a concrete version of the Xen Project CoC based on v1.4 of the Contributor Covenant. See [1]
Closing the discussion
======================
I think we are at the point where we are ready to publish our guidance. Feedback has been minor since the last version and loose ends were primarily to do with missing examples.
To close this, I wanted to get votes on the proposal in the usual way. Technically, only leadership team members of mature projects which are Hypervisor, XAPI and the Windows PV driver project can vote.
However, in this case I do believe we do want to hear voices of others.
Voting would follow the rules outlined in
https://xenproject.org/developers/governance/#project-decisions
Leadership team members should vote by replying if they are happy with the substance of the proposal by using the usual terminology
+2 : I am happy with this proposal, and I will argue for it
+1 : I am happy with this proposal, but will not argue for it 0 : I have no opinion
-1 : I am not happy with this proposal, but will not argue against it -2 : I am not happy with this proposal, and I will argue against it
If there are minor changes (such as typos, etc) we should fix this in due course. If there are major objections, please highlight here but also raise it against the specific patch and make clear what the objection is.
More notes on Changes
=====================
It tries to address all elements in the v2 review, which raised a number of hard questions, which were mostly addressed in v3.
One of the main outstanding items in v3 were good examples for cover letters and well structured large patch series which were added in v4.
For convenience of review and in line with other policy documents I created a git repository at [2]. This series can be found at [3].
I also reformatted the series to 80 characters and replaced inline style links with reference style links to make it easier to stick to a character limit.
[1] https://www.contributor-covenant.org/version/1/4/code-of-conduct.md
[2] http://xenbits.xen.org/gitweb/?p=people/larsk/code-of-conduct.git;a=summary
[3] http://xenbits.xen.org/gitweb/?p=people/larsk/code-of-conduct.git;a=shortlog;h=refs/heads/CoC-v4
Changes since v3
* More typo and whitespace fixes
code-review-guide.md
* Added example under *Workflow from a Reviewer's Perspective* section
Changes since v2
* Reformatted all text to 80 characters and replaced link style
code-review-guide.md
* Extend introduction
* Add "Code Review Workflow" covering
- "Workflow from a Reviewer's Perspective"
- "Workflow from an Author's Perspective"
- "Problematic Patch Reviews"
TODO: find suitable examples on how to structure/describe good patch series
communication-practice.md
* Fix typos
* Extended "Verbose vs. terse"
* Added "Clarity over Verbosity"
* Broke "Identify the severity of an issue or disagreement" into two chapters
- "Identify the severity and optionality of review comments" and made clarifications
- "Identify the severity of a disagreement"
- Expanded "Prioritize significant flaws"
* Added "Reviewers: Take account of previous reviewer(s) comments"
* Added prefixes such as "Reviewers:" where appropriate
resolving-disagreement.md
* Fix typos
* Add section: "Issue: Multiple ways to solve a problem"
Changes since v1
* Code of Conduct
Only whitespace changes
* Added Communication Guide
Contains values and a process based on advice and mediation in case of issues This is the primary portal for
* Added Code Review Guide
Which is based on [4] with some additions for completeness
It primarily sets expectations and anything communication related is removed
* Added guide on Communication Best Practice
Takes the communication section from [4] and expands on it with more examples and cases. This is probably where we may need some discussion
* Added document on Resolving Disagreement
A tiny bit of theory to set the scene
It covers some common cases of disagreements and how we may approach them Again, this probably needs some discussion
Lars Kurth (7):
Import v1.4 of Contributor Covenant CoC
Xen Project Code of Conduct
Reformat Xen Project CoC to fit into 80 character limit Add Communication Guide
Add Code Review Guide
Add guide on Communication Best Practice
Added Resolving Disagreement
--
2.13.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel