Skip to content

drm/i915: modeset probe/remove cleanup

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/i915: register vga switcheroo later, unregister earlierdrivers/gpu/drm/i915/i915_drv.c+9 -100 replies
2/11drm/i915: switch i915_driver_probe() to use i915 local variabledrivers/gpu/drm/i915/i915_drv.c+21 -211 reply
3/11drm/i915: keep power domains init/remove calls at the same leveldrivers/gpu/drm/i915/i915_drv.c+6 -61 reply
4/11drm/i915: split intel_modeset_driver_remove() to pre/post irq uninstalldrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/i915_drv.c+13 -70 replies
5/11drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstalldrivers/gpu/drm/i915/i915_drv.c+9 -20 replies
6/11drm/i915: split i915_driver_modeset_probe() to pre/post irq installdrivers/gpu/drm/i915/i915_drv.c+30 -120 replies
7/11drm/i915: split intel_modeset_init() to pre/post irq installdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/i915_drv.c+20 -40 replies
8/11drm/i915: split intel_modeset_init() pre/post gem initdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/i915_drv.c+27 -140 replies
9/11drm/i915: move more display related probe/remove stuff to displaydrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_drv.c+26 -330 replies
10/11drm/i915: move modeset probe failures down to intel_display.cdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_drv.c+6 -60 replies
11/11drm/i915: remove the now redundant i915_driver_modeset_* call layerdrivers/gpu/drm/i915/i915_drv.c+19 -571 reply

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchLukas WunnerChris Wilson
1/11A-b
2/11R-b
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] drm/i915: modeset probe/remove cleanup

Another attempt at trying to cleanup the probe/remove wrt display. TL;DR: It's a mess.

I'm trying to chop up the intel_modeset_*() functions in intel_display.c to smaller pieces, and eventually remove the extra i915_driver_modeset_*() layer from i915_drv.c.

The intermediate steps aren't the prettiest. The error paths in particular are hideous. (Not that they are great now.)

But I'm trying to probe (eh) if this would be a workable direction.

BR,
Jani.

Jani Nikula (11):
drm/i915: register vga switcheroo later, unregister earlier drm/i915: switch i915_driver_probe() to use i915 local variable drm/i915: keep power domains init/remove calls at the same level drm/i915: split intel_modeset_driver_remove() to pre/post irq
uninstall
drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstall drm/i915: split i915_driver_modeset_probe() to pre/post irq install drm/i915: split intel_modeset_init() to pre/post irq install drm/i915: split intel_modeset_init() pre/post gem init drm/i915: move more display related probe/remove stuff to display drm/i915: move modeset probe failures down to intel_display.c drm/i915: remove the now redundant i915_driver_modeset_* call layer

 drivers/gpu/drm/i915/display/intel_display.c |  82 +++++++--
 drivers/gpu/drm/i915/display/intel_display.h |   3 +
 drivers/gpu/drm/i915/i915_drv.c              | 183 +++++++------------
 3 files changed, 141 insertions(+), 127 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx