Skip to content

drm/print: cleanup and new drm_device based logging

Jani Nikula amd-gfx dri-devel intel-gfx nouveau 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/27 of 8 patches 8 repliesIn review
  2. v1 posting 1/28 patches 2 repliesSuperseded

7 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915: use drm_debug_enabled() to check for debug categoriesdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/i915_drv.c +3 more+7 -70 replies
3/8drm/amdgpu: use drm_debug_enabled() to check for debug categoriesdrivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c+2 -20 replies
4/8drm/print: rename drm_debug to __drm_debug to discourage usedrivers/gpu/drm/drm_print.c include/drm/drm_print.h+7 -60 replies
5/8drm/print: underscore prefix functions that should be private to printdrivers/gpu/drm/drm_print.c include/drm/drm_print.h+15 -151 reply
6/8drm/print: convert debug category macros into an enumdrivers/gpu/drm/drm_print.c include/drm/drm_print.h+63 -422 replies
7/8drm/print: group logging functions by prink or device basedinclude/drm/drm_print.h+74 -611 reply
8/8drm/print: introduce new struct drm_device based logging macrosinclude/drm/drm_print.h+65 -02 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric EngestromAlex DeucherVille SyrjäläJoonas LahtinenRodrigo ViviSean Paul
SeriesA-b
1/8R-b
3/8A-b
4/8R-b A-b
5/8R-b
6/8R-b
7/8R-b
8/8A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH RESEND 0/8] drm/print: cleanup and new drm_device based logging

Resend of [1]; I may have rebased but I'm not sure anymore...

For starters some fairly benign cleanup, and a proposal for new struct drm_device based drm logging macros analoguous to core kernel struct device based macros.

Please let's at least get the first 7 reviewed/acked/merged, shall we?

BR,
Jani.

[1] https://patchwork.freedesktop.org/series/67795/

Jani Nikula (8):
drm/i915: use drm_debug_enabled() to check for debug categories drm/nouveau: use drm_debug_enabled() to check for debug categories drm/amdgpu: use drm_debug_enabled() to check for debug categories drm/print: rename drm_debug to __drm_debug to discourage use drm/print: underscore prefix functions that should be private to print drm/print: convert debug category macros into an enum drm/print: group logging functions by prink or device based drm/print: introduce new struct drm_device based logging macros

 drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c   |   4 +-
 drivers/gpu/drm/drm_print.c                  |  18 +-
 drivers/gpu/drm/i915/display/intel_display.c |   4 +-
 drivers/gpu/drm/i915/display/intel_dp.c      |   2 +-
 drivers/gpu/drm/i915/i915_drv.c              |   2 +-
 drivers/gpu/drm/i915/i915_gem.h              |   2 +-
 drivers/gpu/drm/i915/i915_utils.c            |   2 +-
 drivers/gpu/drm/i915/intel_pm.c              |   2 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.h      |   4 +-
 drivers/gpu/drm/nouveau/nouveau_drv.h        |   4 +-
 include/drm/drm_print.h                      | 304 ++++++++++++-------
 11 files changed, 224 insertions(+), 124 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel