Skip to content

net/sched: fix wrong behavior of MPLS push/pop action

Davide Caratti netdev oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: avoid errors when trying to pop MLPS header on non-MPLS packetsnet/core/skbuff.c+1 -10 replies
2/2net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actionsinclude/linux/skbuff.h net/core/skbuff.c net/openvswitch/actions.c +1 more+25 -160 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSimon HormanJohn Hurley
1/2R-b A-b
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net v2 0/2] net/sched: fix wrong behavior of MPLS push/pop action

this series contains two fixes for TC 'act_mpls', that try to address two problems that can be observed configuring simple 'push' / 'pop' operations:
- patch 1/2 avoids dropping non-MPLS packets that pass through the MPLS 'pop' action.
- patch 2/2 fixes corruption of the L2 header that occurs when 'push' or 'pop' actions are configured in TC egress path.

v2: - change commit message in patch 1/2 to better describe that the
patch impacts only TC, thanks to Simon Horman
- fix missing documentation of 'mac_len' in patch 2/2

Davide Caratti (2):
net: avoid errors when trying to pop MLPS header on non-MPLS packets net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions

 include/linux/skbuff.h    |  5 +++--
 net/core/skbuff.c         | 21 ++++++++++++---------
 net/openvswitch/actions.c |  5 +++--
 net/sched/act_mpls.c      | 12 ++++++++----
 4 files changed, 26 insertions(+), 17 deletions(-)
Signature · 1 line
2.21.0