Skip to content

RFC mptcp: just another recvmsg refactor

Paolo Abeni mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mptcp: move some helper into the header filenet/mptcp/protocol.c net/mptcp/protocol.h+26 -200 replies
2/3mptcp: flush duplicate data at data_ready() timenet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+279 -1883 replies
3/3mptcp: recvmsg() can drain data from multiple subflowsnet/mptcp/protocol.c+111 -630 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [RFC PATCH 0/3] mptcp: just another recvmsg refactor

This start constructing the instrucutre to support pulling data from multiple subflow. At the current stage uses a very simply approach, dropping any out-of-order data and reading from any subflow with valid data.

The above should work quite nicely in active backup scenario and possibly even with multiple subflows sending data concurrently - with a low bwidth and a huge number of retransmissions.

This is a not_so_early draft, shared as it may pave some ground and/or partially overlap with DATA_FIN support effort

Note that this rewrite completely the recvmsg() main loop to mirror more closely the TCP recvmsg() main loop, likely fixing some bug in respect to signal and error condition handling.

Paolo Abeni (3):
mptcp: move some helper into the header file
mptcp: flush duplicate data at data_ready() time
mptcp: recvmsg() can drain data from multiple subflows

 net/mptcp/protocol.c | 360 +++++++++++++------------------------------
 net/mptcp/protocol.h |  31 +++-
 net/mptcp/subflow.c  | 270 +++++++++++++++++++++++++++++++-
 3 files changed, 403 insertions(+), 258 deletions(-)
Signature · 1 line
2.21.0