Skip to content

Remove callback indirections in compression code

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15btrfs: export compression and decompression callbacksfs/btrfs/compression.c fs/btrfs/lzo.c fs/btrfs/zlib.c +1 more+45 -361 reply
2/15btrfs: switch compression callbacks to direct callsfs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +2 more+69 -342 replies
3/15btrfs: compression: attach workspace manager to the opsfs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +2 more+6 -01 reply
4/15btrfs: compression: let workspace manager init take only the typefs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +1 more+7 -71 reply
5/15btrfs: compression: inline init_workspace_managerfs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +2 more+7 -281 reply
6/15btrfs: compression: let workspace manager cleanup take only the typefs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +1 more+7 -51 reply
7/15btrfs: compression: inline cleanup_workspace_managerfs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +2 more+7 -281 reply
8/15btrfs: compression: export alloc/free/get/put callbacks of all algosfs/btrfs/compression.c fs/btrfs/lzo.c fs/btrfs/zlib.c +1 more+26 -151 reply
9/15btrfs: compression: inline get_workspacefs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +2 more+15 -181 reply
10/15btrfs: compression: inline put_workspacefs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +2 more+15 -241 reply
11/15btrfs: compression: pass type to btrfs_get_workspacefs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/zlib.c+7 -101 reply
12/15btrfs: compression: inline alloc_workspacefs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +2 more+18 -81 reply
13/15btrfs: compression: pass type to btrfs_put_workspacefs/btrfs/compression.c fs/btrfs/compression.h+7 -81 reply
14/15btrfs: compression: inline free_workspacefs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/lzo.c +2 more+18 -81 reply
15/15btrfs: compression: remove ops pointer from workspace_managerfs/btrfs/compression.c fs/btrfs/compression.h+2 -51 reply

Reviews trailers per patch

14 of 15 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohannes ThumshirnNikolay Borisov
SeriesR-b
1/15R-b
2/15
3/15R-b
4/15R-b
5/15R-b
6/15R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b
12/15R-b
13/15R-b
14/15R-b
15/15R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/15] Remove callback indirections in compression code

The series removes all per-compression algorithm callbacks and replaces them with a switches. Lots of indirections are simplified and while it looks nice from design POV, we don't need to over-engineer it as we have only fixed known number of the users and not public API.

The cost of indirect function calls is also higher with enabled mitigations of the spectre vulnerability, so they've been incrementally removed from the whole kernel and from btrfs as well.

David Sterba (15):
btrfs: export compression and decompression callbacks
btrfs: switch compression callbacks to direct calls
btrfs: compression: attach workspace manager to the ops
btrfs: compression: let workspace manager init take only the type
btrfs: compression: inline init_workspace_manager
btrfs: compression: let workspace manager cleanup take only the type
btrfs: compression: inline cleanup_workspace_manager
btrfs: compression: export alloc/free/get/put callbacks of all algos
btrfs: compression: inline get_workspace
btrfs: compression: inline put_workspace
btrfs: compression: pass type to btrfs_get_workspace
btrfs: compression: inline alloc_workspace
btrfs: compression: pass type to btrfs_put_workspace
btrfs: compression: inline free_workspace
btrfs: compression: remove ops pointer from workspace_manager

 fs/btrfs/compression.c | 241 +++++++++++++++++++++++++++++++----------
 fs/btrfs/compression.h |  39 +------
 fs/btrfs/lzo.c         |  53 ++-------
 fs/btrfs/zlib.c        |  52 ++-------
 fs/btrfs/zstd.c        |  47 +++-----
 5 files changed, 227 insertions(+), 205 deletions(-)
Signature · 1 line
2.23.0