OpenPandora: make wl1251 connected to mmc3 sdio port of OpenPandora work again
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest12 patches 10 repliesIn review
- v211 patches 12 repliesSuperseded
- v19 patches 6 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | Documentation: dt: wireless: update wl1251 for sdioDocumentation/ | +26 | 2 replies | |
| 2/12 | net: wireless: ti: wl1251 add device tree supportdrivers/ | +13 | 1 reply | |
| 3/12 | ARM: dts: pandora-common: define wl1251 as child node of mmc3arch/ | +34 | 1 reply | |
| 4/12 | mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_carddrivers/ | +28 | 0 replies | |
| 5/12 | omap: pdata-quirks: revert pandora specific gpiod additionsarch/ | +4 | 1 reply | |
| 6/12 | omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251arch/ | +0 | 1 reply | |
| 7/12 | omap: remove omap2_hsmmc_info in old hsmmc.[ch] and update Makefilearch/ arch/ arch/ +2 more | +0 | 1 reply | |
| 8/12 | mmc: host: omap-hsmmc: remove init_card pdata callback from pdatadrivers/ include/ | +1 | 0 replies | |
| 9/12 | mmc: sdio: fix wl1251 vendor idinclude/ | +2 | 0 replies | |
| 10/12 | mmc: core: fix wl1251 sdio quirksdrivers/ | +7 | 0 replies | |
| 11/12 | net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definitiondrivers/ | +1 | 0 replies | |
| 12/12 | net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitionsdrivers/ drivers/ | +0 | 0 replies |
Reviews trailers per patch
8 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Kalle Valo | Tony Lindgren | Rob Herring |
|---|---|---|---|
| 1/12 | A-b | R-b | |
| 2/12 | A-b | ||
| 3/12 | A-b | ||
| 4/12 | |||
| 5/12 | A-b | ||
| 6/12 | A-b | ||
| 7/12 | A-b | ||
| 8/12 | |||
| 9/12 | |||
| 10/12 | |||
| 11/12 | A-b | ||
| 12/12 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 00/12] OpenPandora: make wl1251 connected to mmc3 sdio port of OpenPandora work again
* add a revisit note for special wl1251 handling code because it should
be solved more generic in mmc core - suggested by Ulf Hansson <[email protected]>
* remove init_card callback from platform_data/hsmmc-omap.h - suggested by Ulf Hansson <[email protected]>
* remove obstructive always-on for vwlan regulator - suggested by Ulf Hansson <[email protected]>
* rename DT node - suggested by Rob Herring <[email protected]>
* fix ARM: dts: subject prefix - suggested by Tony Lindgren <[email protected]>
* also remove omap2_hsmmc_info and obc-y line in Makefile - suggested by Tony Lindgren <[email protected]>
PATCH V2 2019-10-19 20:41:47:
* added acked-by for wl1251 patches - Kalle Valo <[email protected]>
* really removed old pdata-quirks code (not through #if 0)
* splited out a partial revert of
efdfeb079cc3b ("regulator: fixed: Convert to use GPIO descriptor only")
because that was introduced after v4.19 and stops the removal of the pdata-quirks patch from cleanly applying to v4.9, v4.14, v4.19
- reported by Sasha Levin <[email protected]>
* added a new patch to remove old omap hsmmc since pdata quirks were last user - suggested by Tony Lindgren <[email protected]>
PATCH V1 2019-10-18 22:25:39:
Here we have a set of scattered patches to make the OpenPandora WiFi work again.
v4.7 did break the pdata-quirks which made the mmc3 interface fail completely, because some code now assumes device tree based instantiation.
v4.11 did break the sdio qirks for wl1251 which made the driver no longer load, although the device was found as an sdio client.
To solve these issues:
* we convert mmc3 and wl1251 initialization from pdata-quirks to device tree
* we make the wl1251 driver read properties from device tree
* we fix the mmc core vendor ids and quirks
* we fix the wl1251 (and wl1271) driver to use only vendor ids from header file instead of (potentially conflicting) local definitions
H. Nikolaus Schaller (12):
Documentation: dt: wireless: update wl1251 for sdio
net: wireless: ti: wl1251 add device tree support
ARM: dts: pandora-common: define wl1251 as child node of mmc3
mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid
of pandora_wl1251_init_card
omap: pdata-quirks: revert pandora specific gpiod additions
omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251
omap: remove omap2_hsmmc_info in old hsmmc.[ch] and update Makefile
mmc: host: omap-hsmmc: remove init_card pdata callback from pdata
mmc: sdio: fix wl1251 vendor id
mmc: core: fix wl1251 sdio quirks
net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition
net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions
.../bindings/net/wireless/ti,wl1251.txt | 26 +++ arch/arm/boot/dts/omap3-pandora-common.dtsi | 36 +++- arch/arm/mach-omap2/Makefile | 3 - arch/arm/mach-omap2/common.h | 1 - arch/arm/mach-omap2/hsmmc.c | 171 ------------------ arch/arm/mach-omap2/hsmmc.h | 32 ---- arch/arm/mach-omap2/pdata-quirks.c | 105 ----------- drivers/mmc/core/quirks.h | 7 + drivers/mmc/host/omap_hsmmc.c | 30 ++- drivers/net/wireless/ti/wl1251/sdio.c | 23 ++- drivers/net/wireless/ti/wlcore/sdio.c | 8 - include/linux/mmc/sdio_ids.h | 2 + include/linux/platform_data/hsmmc-omap.h | 3 - 13 files changed, 111 insertions(+), 336 deletions(-) delete mode 100644 arch/arm/mach-omap2/hsmmc.c delete mode 100644 arch/arm/mach-omap2/hsmmc.h
Signature · 1 line
2.23.0