Skip to content

Block group structure cleanups

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6btrfs: move block_group_item::used to block groupfs/btrfs/block-group.c fs/btrfs/block-group.h fs/btrfs/extent-tree.c +8 more+42 -341 reply
2/6btrfs: move block_group_item::flags to block groupfs/btrfs/block-group.c+3 -31 reply
3/6btrfs: remove embedded block_group_cache::itemfs/btrfs/block-group.c fs/btrfs/block-group.h+5 -121 reply
4/6btrfs: rename block_group_item on-stack accessors to follow namingfs/btrfs/block-group.c fs/btrfs/ctree.h fs/btrfs/tree-checker.c+17 -171 reply
5/6btrfs: rename extent buffer block group item accessorsfs/btrfs/ctree.h fs/btrfs/print-tree.c+6 -61 reply
6/6btrfs: add dedicated members for start and length of a block groupfs/btrfs/block-group.c fs/btrfs/block-group.h fs/btrfs/extent-tree.c +12 more+210 -2242 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchQu WenruoJohannes ThumshirnNikolay Borisov
SeriesR-b R-b
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] Block group structure cleanups

The block group cache structure has two embedded members that belong to the on-disk format but were used for the in-memory structures. It's been like that forever and I wonder why nobody was bothered by that. Switch to normal members and rename a few things on along the way.

The size of block_group_cache is down from 528 to 504 so it should not fit better to slab pages. Further shrinkage is possible.

David Sterba (6):
btrfs: move block_group_item::used to block group
btrfs: move block_group_item::flags to block group
btrfs: remove embedded block_group_cache::item
btrfs: rename block_group_item on-stack accessors to follow naming
btrfs: rename extent buffer block group item accessors
btrfs: add dedicated members for start and length of a block group

 fs/btrfs/block-group.c                 | 191 +++++++++++++------------
 fs/btrfs/block-group.h                 |   5 +-
 fs/btrfs/ctree.h                       |  12 +-
 fs/btrfs/extent-tree.c                 |  31 ++--
 fs/btrfs/free-space-cache.c            |  39 +++--
 fs/btrfs/free-space-tree.c             |  83 ++++++-----
 fs/btrfs/ioctl.c                       |   5 +-
 fs/btrfs/print-tree.c                  |   6 +-
 fs/btrfs/reada.c                       |   4 +-
 fs/btrfs/relocation.c                  |  18 +--
 fs/btrfs/scrub.c                       |  10 +-
 fs/btrfs/space-info.c                  |   3 +-
 fs/btrfs/sysfs.c                       |   4 +-
 fs/btrfs/tests/btrfs-tests.c           |   5 +-
 fs/btrfs/tests/free-space-tree-tests.c |  75 +++++-----
 fs/btrfs/tree-checker.c                |  10 +-
 fs/btrfs/volumes.c                     |  19 ++-
 include/trace/events/btrfs.h           |  21 ++-
 18 files changed, 264 insertions(+), 277 deletions(-)
Signature · 1 line
2.23.0