Block group structure cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | btrfs: move block_group_item::used to block groupfs/ fs/ fs/ +8 more | +42 | 1 reply | |
| 2/6 | btrfs: move block_group_item::flags to block groupfs/ | +3 | 1 reply | |
| 3/6 | btrfs: remove embedded block_group_cache::itemfs/ fs/ | +5 | 1 reply | |
| 4/6 | btrfs: rename block_group_item on-stack accessors to follow namingfs/ fs/ fs/ | +17 | 1 reply | |
| 5/6 | btrfs: rename extent buffer block group item accessorsfs/ fs/ | +6 | 1 reply | |
| 6/6 | btrfs: add dedicated members for start and length of a block groupfs/ fs/ fs/ +12 more | +210 | 2 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Qu Wenruo | Johannes Thumshirn | Nikolay Borisov |
|---|---|---|---|
| Series | R-b | R-b | |
| 1/6 | R-b | ||
| 2/6 | R-b | ||
| 3/6 | R-b | ||
| 4/6 | R-b | ||
| 5/6 | R-b | ||
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/6] Block group structure cleanups
The block group cache structure has two embedded members that belong to the on-disk format but were used for the in-memory structures. It's been like that forever and I wonder why nobody was bothered by that. Switch to normal members and rename a few things on along the way.
The size of block_group_cache is down from 528 to 504 so it should not fit better to slab pages. Further shrinkage is possible.
David Sterba (6):
btrfs: move block_group_item::used to block group
btrfs: move block_group_item::flags to block group
btrfs: remove embedded block_group_cache::item
btrfs: rename block_group_item on-stack accessors to follow naming
btrfs: rename extent buffer block group item accessors
btrfs: add dedicated members for start and length of a block group
fs/btrfs/block-group.c | 191 +++++++++++++------------ fs/btrfs/block-group.h | 5 +- fs/btrfs/ctree.h | 12 +- fs/btrfs/extent-tree.c | 31 ++-- fs/btrfs/free-space-cache.c | 39 +++-- fs/btrfs/free-space-tree.c | 83 ++++++----- fs/btrfs/ioctl.c | 5 +- fs/btrfs/print-tree.c | 6 +- fs/btrfs/reada.c | 4 +- fs/btrfs/relocation.c | 18 +-- fs/btrfs/scrub.c | 10 +- fs/btrfs/space-info.c | 3 +- fs/btrfs/sysfs.c | 4 +- fs/btrfs/tests/btrfs-tests.c | 5 +- fs/btrfs/tests/free-space-tree-tests.c | 75 +++++----- fs/btrfs/tree-checker.c | 10 +- fs/btrfs/volumes.c | 19 ++- include/trace/events/btrfs.h | 21 ++- 18 files changed, 264 insertions(+), 277 deletions(-)
Signature · 1 line
2.23.0