Skip to content

staging: vc04_services: Remove typedefs

Jamal Shareef outreachy 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 8 repliesIn review
  2. v48 patches 2 repliesSuperseded
  3. v38 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches1 replySuperseded
v12 patches3 repliesSuperseded

Changes in v5 from the cover letter

- Separate vchi typedef structs into individual patches for each struct (now Patch 1 and 2).
- Retain callback function pointer typedefs but Rename them to match kernel code style (Patch 3, 5, 6, 7).
- Separate vchiq typedef structs into individual patches for each struct (now Patch 9 and 10).

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10staging: vc04_services: Remove instance struct typedefdrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c drivers/staging/vc04_services/bcm2835-audio/bcm2835.h drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +3 more+31 -322 replies
2/10staging: vc04_services: remove service struct typedefdrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c drivers/staging/vc04_services/interface/vchi/vchi.h +1 more+50 -500 replies
3/10staging: vc04_services: Rename function pointer typedefdrivers/staging/vc04_services/interface/vchi/vchi.h drivers/staging/vc04_services/interface/vchi/vchi_common.h drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c+6 -60 replies
4/10staging: vc04_services: Remove vchiq_arm enum typedefsdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h +5 more+191 -1901 reply
5/10staging: vc04_services: Rename userdata callbackdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h+8 -80 replies
6/10staging: vc04_services: Renames vchiq callbackdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h+3 -30 replies
7/10staging: vc04_services: Renames remote use callbackdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h+2 -24 replies
8/10staging: vc04_services: Remove int typedefdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +3 more+65 -680 replies
9/10staging: vc04_services: Remove vchiq instance typedefsdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +5 more+66 -640 replies
10/10staging: vc04_services: Removes platform struct typedefdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h+2 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 00/10] staging: vc04_services: Remove typedefs

This patch removes typedefs from vc04_services files. Renames callback function typedefs to match kernel code style.

Changes in v5:
- Separate vchi typedef structs into individual patches for each struct (now Patch 1 and 2).
- Retain callback function pointer typedefs but Rename them to match kernel code style (Patch 3, 5, 6, 7).
- Separate vchiq typedef structs into individual patches for each struct (now Patch 9 and 10).

Changes in v4:
- Place removal of VCHIQ_USERDATA_TERM_T callback into callback patch (Patch 6). Was in struct patch (Patch 8) previously.

Changes in v3:
- Separate removal of unused opaque struct typedefs that were remaining in the vchi enum typedef patch to a separate patch (now Patch 1).
- Remove formatting in vchi enum typedef Patch 2 which was better served in Patch 3.

Changes in v2:
- Split patches into smaller patches limitied to typedef type. Patch 8:
- Rename "struct vchiq_instance_struct' to "struct vchiq_instance" due to wordiness and agreement between header files.

Jamal Shareef (10):
staging: vc04_services: Remove instance struct typedef
staging: vc04_services: remove service struct typedef
staging: vc04_services: Rename function pointer typedef
staging: vc04_services: Remove vchiq_arm enum typedefs
staging: vc04_services: Rename userdata callback
staging: vc04_services: Renames vchiq callback
staging: vc04_services: Renames remote use callback
staging: vc04_services: Remove int typedef
staging: vc04_services: Remove vchiq instance typedefs
staging: vc04_services: Removes platform struct typedef

 .../bcm2835-audio/bcm2835-vchiq.c             |   4 +-
 .../vc04_services/bcm2835-audio/bcm2835.h     |   2 +-
 .../vc04_services/bcm2835-camera/mmal-vchiq.c |   4 +-
 .../vc04_services/interface/vchi/vchi.h       |  56 +++---
 .../interface/vchi/vchi_common.h              |   7 +-
 .../interface/vchiq_arm/vchiq_2835_arm.c      |  10 +-
 .../interface/vchiq_arm/vchiq_arm.c           | 170 +++++++++---------
 .../interface/vchiq_arm/vchiq_arm.h           |  32 ++--
 .../interface/vchiq_arm/vchiq_core.c          | 116 ++++++------
 .../interface/vchiq_arm/vchiq_core.h          |  91 +++++-----
 .../interface/vchiq_arm/vchiq_debugfs.c       |  14 +-
 .../interface/vchiq_arm/vchiq_debugfs.h       |   4 +-
 .../interface/vchiq_arm/vchiq_if.h            |  93 +++++-----
 .../interface/vchiq_arm/vchiq_ioctl.h         |   4 +-
 .../interface/vchiq_arm/vchiq_shim.c          | 132 +++++++-------
 15 files changed, 369 insertions(+), 370 deletions(-)
Signature · 1 line
2.17.1