Skip to content

staging: vc04_services: Replace typedefs and

Jamal Shareef outreachy 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest14 patches 1 replyIn review

Changes in v2 from the cover letter

- Rewrite patch subject lines and body to be more descriptive for all patches.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14staging: vc04_services: Replace VCHI_INSTANCE_T with struct vhci_instance_handledrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c drivers/staging/vc04_services/bcm2835-audio/bcm2835.h drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +2 more+18 -180 replies
2/14staging: vc04_services: Replace VCHI_SERVICE_HANDLE_T typedef with struct vchi_service_handledrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c drivers/staging/vc04_services/interface/vchi/vchi.h +1 more+48 -480 replies
3/14staging: vc04_services: Rename callback VCHI_CALLBACK_T to vchi_callbackdrivers/staging/vc04_services/interface/vchi/vchi.h drivers/staging/vc04_services/interface/vchi/vchi_common.h drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c+5 -50 replies
4/14staging: vc04_services: Replace VCHIQ_STATUS_T enum typedef with enum vchiq_statusdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h +4 more+133 -1331 reply
5/14staging: vc04_services: Replace VCHIQ_BULK_MODE_T enum typedef with enum vchiq_bulk_modedrivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h +3 more+15 -150 replies
6/14staging: vc04_services: Replace VCHIQ_SERVICE_OPTION_T enum typedef with enum vchiq_service_optiondrivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h +1 more+6 -60 replies
7/14staging: vc04_services: Replace VCHIQ_CONNSTATE_T enum typedef with enum vchiq_connstatedrivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h+12 -120 replies
8/14staging: vc04_services: Replace VCHIQ_BULK_DIR_T enum typedef with enum vchiq_bulk_dirdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h+7 -70 replies
9/14staging: vc04_services: Rename callback VCHIQ_USERDATA_TERM_T to vchiq_userdata_termdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h+4 -40 replies
10/14staging: vc04_services: Rename VCHIQ_CALLBACK_T to vchiq_callbackdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h+5 -50 replies
11/14staging: vc04_services: Rename VCHIQ_REMOTE_USE_CALLBACK_T to vchiq_remote_callbackdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h+2 -20 replies
12/14staging: vc04_services: Replace VCHIQ_SERVICE_HANDLE_T typedef with unsigned intdrivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +3 more+61 -630 replies
13/14staging: vc04_services: Replace VCHIQ_INSTANCE_T typedef with struct vchiq_instancedrivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +5 more+64 -640 replies
14/14staging: vc04_services: Replace VCHIQ_PLATFORM_STATE_T typedef with struct opaque_platform_statedrivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/14] staging: vc04_services: Replace typedefs and

This patchset replaces typedefs with native types where feasible and renames callback functions to match kernel code style.

Changes in v2:
- Rewrite patch subject lines and body to be more descriptive for all patches.

Jamal Shareef (14):
staging: vc04_services: Replace VCHI_INSTANCE_T with struct
vhci_instance_handle
staging: vc04_services: Replace VCHI_SERVICE_HANDLE_T typedef with
struct vchi_service_handle
staging: vc04_services: Rename callback VCHI_CALLBACK_T to
vchi_callback
staging: vc04_services: Replace VCHIQ_STATUS_T enum typedef with enum
vchiq_status
staging: vc04_services: Replace VCHIQ_BULK_MODE_T enum typedef with
enum vchiq_bulk_mode
staging: vc04_services: Replace VCHIQ_SERVICE_OPTION_T enum typedef
with enum vchiq_service_option
staging: vc04_services: Replace VCHIQ_CONNSTATE_T enum typedef with
enum vchiq_connstate
staging: vc04_services: Replace VCHIQ_BULK_DIR_T enum typedef with
enum vchiq_bulk_dir
staging: vc04_services: Rename callback VCHIQ_USERDATA_TERM_T to
vchiq_userdata_term
staging: vc04_services: Rename VCHIQ_CALLBACK_T to vchiq_callback
staging: vc04_services: Rename VCHIQ_REMOTE_USE_CALLBACK_T to
vchiq_remote_callback
staging: vc04_services: Replace VCHIQ_SERVICE_HANDLE_T typedef with
unsigned int
staging: vc04_services: Replace VCHIQ_INSTANCE_T typedef with struct
vchiq_instance
staging: vc04_services: Replace VCHIQ_PLATFORM_STATE_T typedef with
struct opaque_platform_state

 .../bcm2835-audio/bcm2835-vchiq.c             |   4 +-
 .../vc04_services/bcm2835-audio/bcm2835.h     |   2 +-
 .../vc04_services/bcm2835-camera/mmal-vchiq.c |   4 +-
 .../vc04_services/interface/vchi/vchi.h       |  56 +++---
 .../interface/vchi/vchi_common.h              |   6 +-
 .../interface/vchiq_arm/vchiq_2835_arm.c      |  10 +-
 .../interface/vchiq_arm/vchiq_arm.c           | 170 +++++++++---------
 .../interface/vchiq_arm/vchiq_arm.h           |  32 ++--
 .../interface/vchiq_arm/vchiq_core.c          | 116 ++++++------
 .../interface/vchiq_arm/vchiq_core.h          |  88 ++++-----
 .../interface/vchiq_arm/vchiq_debugfs.c       |  14 +-
 .../interface/vchiq_arm/vchiq_debugfs.h       |   4 +-
 .../interface/vchiq_arm/vchiq_if.h            |  92 +++++-----
 .../interface/vchiq_arm/vchiq_ioctl.h         |   4 +-
 .../interface/vchiq_arm/vchiq_shim.c          | 116 ++++++------
 15 files changed, 358 insertions(+), 360 deletions(-)
Signature · 1 line
2.17.1