add DMA-sync-for-device capability to page_pool API
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 10 repliesIn review
- v43 patches 15 repliesSuperseded
- v33 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 0 replies | Superseded | |
| v1 | 3 patches | 17 replies | Superseded |
Changes in v5 from the cover letter
- do not allow the driver to set max_len to 0
- convert PP_FLAG_DMA_MAP/PP_FLAG_DMA_SYNC_DEV to BIT() macro
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | net: mvneta: rely on page_pool_recycle_direct in mvneta_run_xdpdrivers/ | +4 | 1 reply | |
| 2/3 | net: page_pool: add the possibility to sync DMA memory for deviceinclude/ net/ | +52 | 4 replies | |
| 3/3 | net: mvneta: get rid of huge dma sync in mvneta_rx_refilldrivers/ | +15 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Matteo Croce | Jesper Dangaard Brouer | Ilias Apalodimas |
|---|---|---|---|
| Series | A-b | ||
| 1/3 | A-b | ||
| 2/3 | T-b | A-b | |
| 3/3 | T-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v5 net-next 0/3] add DMA-sync-for-device capability to page_pool API
Introduce the possibility to sync DMA memory for device in the page_pool API. This feature allows to sync proper DMA size and not always full buffer (dma_sync_single_for_device can be very costly).
Please note DMA-sync-for-CPU is still device driver responsibility. Relying on page_pool DMA sync mvneta driver improves XDP_DROP pps of about 170Kpps:
- XDP_DROP DMA sync managed by mvneta driver: ~420Kpps
- XDP_DROP DMA sync managed by page_pool API: ~585Kpps
Do not change naming convention for the moment since the changes will hit other drivers as well. I will address it in another series.
Changes since v4:
- do not allow the driver to set max_len to 0
- convert PP_FLAG_DMA_MAP/PP_FLAG_DMA_SYNC_DEV to BIT() macro
Changes since v3:
- move dma_sync_for_device before putting the page in ptr_ring in __page_pool_recycle_into_ring since ptr_ring can be consumed concurrently. Simplify the code moving dma_sync_for_device before running __page_pool_recycle_direct/__page_pool_recycle_into_ring
Changes since v2:
- rely on PP_FLAG_DMA_SYNC_DEV flag instead of dma_sync
Changes since v1:
- rename sync in dma_sync
- set dma_sync_size to 0xFFFFFFFF in page_pool_recycle_direct and page_pool_put_page routines
- Improve documentation
Lorenzo Bianconi (3):
net: mvneta: rely on page_pool_recycle_direct in mvneta_run_xdp
net: page_pool: add the possibility to sync DMA memory for device
net: mvneta: get rid of huge dma sync in mvneta_rx_refill
drivers/net/ethernet/marvell/mvneta.c | 24 +++++++++++------- include/net/page_pool.h | 24 +++++++++++++----- net/core/page_pool.c | 36 +++++++++++++++++++++++++-- 3 files changed, 67 insertions(+), 17 deletions(-)
Signature · 1 line
2.21.0