Skip to content

mptcp: fix for ipv6-related oops

Paolo Abeni mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

v1 -> v2 from the cover letter

- address Matt feedback on patches 1 && 2
- add missing mptcp_v6 proto registration (I don't know why the previous iteration of these patches did not explode without that!!! :(((

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3selftests: fixup for IPv6 teststools/testing/selftests/net/mptcp/mptcp_connect.sh+11 -230 replies
2/3mptcp: use ipv6-specific proto structnet/mptcp/protocol.c+15 -20 replies
3/3mptcp/ipv6: mptcp_v6_prot needs costom destroy.net/mptcp/protocol.c+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [PATCH 0/3] mptcp: fix for ipv6-related oops

We need to allocate a larger struct sock for mptcp v6 master sockets, otherwise inet6_sk() will access mptcp related data instead of struct ipv6_pinfo.

This should fix the crash reported by Matt.

The protocol.c code changes are split in 2 patches to simplify the squashing.
(yep, I know we somewhat agreed to big giant rebase, but this specific should be trivial).

Additionally adds some fixlet for the ipv6 tests

v1 -> v2:
- address Matt feedback on patches 1 && 2
- add missing mptcp_v6 proto registration (I don't know why the previous iteration of these patches did not explode without that!!! :(((

Paolo Abeni (3):
selftests: fixup for IPv6 tests
mptcp: use ipv6-specific proto struct
mptcp/ipv6: mptcp_v6_prot needs costom destroy.

 net/mptcp/protocol.c                          | 24 +++++++++++--
 .../selftests/net/mptcp/mptcp_connect.sh      | 34 ++++++-------------
 2 files changed, 33 insertions(+), 25 deletions(-)
Signature · 1 line
2.21.0