Skip to content

RFC cleanup io_put/free

Pavel Begunkov io-uring 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4io_uring: remove io_free_req_find_next()fs/io_uring.c+2 -70 replies
2/4io_uring: pass only !null to io_req_find_next()fs/io_uring.c+7 -20 replies
3/4io_uring: simplify io_req_link_next()fs/io_uring.c+1 -100 replies
4/4io_uring: only !null ptr to io_issue_sqe()fs/io_uring.c+12 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/4] cleanup io_put/free

Nested checking @nxt for non-nullness in io_put_req_find_next() and friends is a nuisance. Make them accept only non-null @nxt obliging callers to io_queue_async_work() if they don't need @nxt.

The patchset is a bit rusty (rebased), but still relevant. The part removing io_wq_current_is_worker() (PATCH 2/4) looks good, but would like someone to check the assumption.

P.S. it depends on the patch with renaming __io_submit_sqe().

Pavel Begunkov (4):
io_uring: remove io_free_req_find_next()
io_uring: pass only !null to io_req_find_next()
io_uring: simplify io_req_link_next()
io_uring: only !null ptr to io_issue_sqe()

 fs/io_uring.c | 51 +++++++++++++++++++--------------------------------
 1 file changed, 19 insertions(+), 32 deletions(-)
Signature · 1 line
2.24.0