Skip to content

Advice upon clone --recurse-submodules --reference

Jonathan Tan git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Doc: explain submodule.alternateErrorStrategyDocumentation/config/submodule.txt+3 -10 replies
2/2submodule--helper: advise on fatal alternate errorDocumentation/config/advice.txt advice.c advice.h +1 more+16 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Advice upon clone --recurse-submodules --reference

Thanks everyone! Here's an updated v2 following Peff's suggestions on how to write the advice part.

Making submodule.alternateErrorStrategy default to 'info' is reasonable, but I don't know how much it matters in practice - here, submodule.alternateLocation was set because of "clone --recurse-submodules --reference", which also sets submodule.alternateErrorStrategy. I don't know when submodule.alternateLocation would ever be set alone, but then again, I'm not very familiar with this part. I've left that alone for now.

Jonathan Tan (2):
Doc: explain submodule.alternateErrorStrategy
submodule--helper: advise on fatal alternate error

 Documentation/config/advice.txt    |  3 +++
 Documentation/config/submodule.txt |  4 +++-
 advice.c                           |  2 ++
 advice.h                           |  1 +
 builtin/submodule--helper.c        | 10 ++++++++++
 5 files changed, 19 insertions(+), 1 deletion(-)
Signature · 1 line
2.24.0.393.g34dc348eaf-goog