Skip to content

ethtool netlink interface, preliminary part

Michal Kubecek lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 5 repliesIn review
  2. v25 patches 11 repliesSuperseded
  3. v15 patches 4 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rtnetlink: provide permanent hardware address in RTM_NEWLINKinclude/uapi/linux/if_link.h net/core/rtnetlink.c+6 -00 replies
2/5netlink: rename nl80211_validate_nested() to nla_validate_nested()include/net/netlink.h net/wireless/nl80211.c+5 -60 replies
3/5ethtool: move to its own directorynet/Makefile net/core/Makefile net/ethtool/Makefile +1 more+5 -20 replies
4/5ethtool: move string arrays into common filenet/ethtool/Makefile net/ethtool/common.c net/ethtool/common.h +1 more+105 -831 reply
5/5ethtool: provide link mode names as a string setinclude/uapi/linux/ethtool.h net/ethtool/common.c net/ethtool/common.h +1 more+99 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJiri PirkoStephen HemmingerJohannes BergFlorian FainelliAndrew LunnJakub Kicinski
SeriesR-b
1/5A-b A-b
2/5A-b R-b
3/5A-b R-b
4/5R-b R-b
5/5R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 0/5] ethtool netlink interface, preliminary part

As Jakub Kicinski suggested in ethtool netlink v7 discussion, this submission consists only of preliminary patches which raised no objections; first four patches already have Acked-by or Reviewed-by.

- patch 1 exposes permanent hardware address (as shown by "ethtool -P") via rtnetlink
- patch 2 is renames existing netlink helper to a better name
- patch 3 and 4 reorganize existing ethtool code (no functional change)
- patch 5 makes the table of link mode names available as an ethtool string set (will be needed for the netlink interface)

Once we get these out of the way, v8 of the first part of the ethtool netlink interface will follow.

Changes from v2 to v3: fix SPDX licence identifiers (patch 3 and 5).

Changes from v1 to v2: restore build time check that all link modes have assigned a name (patch 5).

Michal Kubecek (5):
rtnetlink: provide permanent hardware address in RTM_NEWLINK
netlink: rename nl80211_validate_nested() to nla_validate_nested()
ethtool: move to its own directory
ethtool: move string arrays into common file
ethtool: provide link mode names as a string set

 include/net/netlink.h                   |   8 +-
 include/uapi/linux/ethtool.h            |   2 +
 include/uapi/linux/if_link.h            |   1 +
 net/Makefile                            |   2 +-
 net/core/Makefile                       |   2 +-
 net/core/rtnetlink.c                    |   5 +
 net/ethtool/Makefile                    |   3 +
 net/ethtool/common.c                    | 171 ++++++++++++++++++++++++
 net/ethtool/common.h                    |  22 +++
 net/{core/ethtool.c => ethtool/ioctl.c} |  90 ++-----------
 net/wireless/nl80211.c                  |   3 +-
 11 files changed, 219 insertions(+), 90 deletions(-)
 create mode 100644 net/ethtool/Makefile
 create mode 100644 net/ethtool/common.c
 create mode 100644 net/ethtool/common.h
 rename net/{core/ethtool.c => ethtool/ioctl.c} (95%)
Signature · 1 line
2.24.0