Skip to content

mptcp: fallback socket cleanup

Paolo Abeni mptcp 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v14 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mptcp: clear 'is_tcp' socket flag when the MP_CAPABLE handshake failsnet/mptcp/options.c net/mptcp/subflow.c+5 -00 replies
2/4mptcp: cleanup fallback handlingnet/mptcp/protocol.c+111 -671 reply
3/4mptcp: add subflow to conn_list earlynet/mptcp/protocol.c+3 -100 replies
4/4mptcp: avoid acquiring the msk lock in mptcp_finisch_connect()net/mptcp/protocol.c+86 -1481 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [MPTCP] [PATCH v2 0/4] mptcp: fallback socket cleanup

This addresses feedback from Mat on v1

From the original cover letter:
---

After all the above, performance for connection fallen back to plain TCP should be almost the same of TCP connection on unpacked kernel.

Addittionally 'nc' and 'netperf' now run successfully when forced to MPTCP. The latter still report a non fatal error at connection closing time as it performs:

getsockopt(4, SOL_TCP, TCP_MAXSEG, //...);
getsockopt(4, SOL_TCP, TCP_INFO, //...);

which is still unsupported after that the mp capable handshake is started.

For the records on the debug build I'm using netperf scores better result with MPTCP that with plain TCP ;) [agreed, completely irrelevant, still nice]

The series applies at selftests and is unsquashed - will require quite a bit of work there and more work to rebase/adjust the patches after kselftest. I'll start that after the pending patches are in.

_Any_ feedback _very_ welcome!

Paolo Abeni (4):
mptcp: clear 'is_tcp' socket flag when the MP_CAPABLE handshake fails
mptcp: cleanup fallback handling
mptcp: add subflow to conn_list early
mptcp: avoid acquiring the msk lock in mptcp_finisch_connect()

 net/mptcp/options.c  |   3 +
 net/mptcp/protocol.c | 353 ++++++++++++++++++++-----------------------
 net/mptcp/subflow.c  |   2 +
 3 files changed, 169 insertions(+), 189 deletions(-)
Signature · 1 line
2.21.0