Skip to content

V2: Break up from one patch to multiple

Scott Schafer lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest23 patches 11 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23staging: qlge: Fix CHECK extra blank lines in many filesdrivers/staging/qlge/qlge.h drivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_ethtool.c +2 more+0 -130 replies
2/23staging: qlge: Fix CHECK: Alignment should match open parenthesisdrivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_ethtool.c drivers/staging/qlge/qlge_main.c +1 more+117 -1300 replies
3/23staging:qlge: Fix WARNING: Missing a blank line after declarationsdrivers/staging/qlge/qlge.h drivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_main.c +1 more+25 -01 reply
4/23staging: qlge: Fix WARNING: Missing a blank line after declarationsdrivers/staging/qlge/qlge.h drivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_main.c +1 more+25 -251 reply
5/23staging: qlge: Fix CHECK: Blank lines aren't necessary before a close brace '}'drivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_main.c drivers/staging/qlge/qlge_mpi.c+0 -80 replies
6/23staging: qlge: Fix CHECK: Blank lines aren't necessary after an open brace '{'drivers/staging/qlge/qlge.h drivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_main.c +1 more+0 -120 replies
7/23staging: qlge: Fix WARNING: quoted string split across linesdrivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_main.c+15 -170 replies
8/23staging: qlge: Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_headerdrivers/staging/qlge/qlge_dbg.c+2 -20 replies
9/23staging: qlge: Fix CHECK: No space is necessary after a castdrivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_main.c+33 -330 replies
10/23staging: qlge: Fix CHECK: blank line after function/struct/union/enum declarationsdrivers/staging/qlge/qlge_ethtool.c+1 -00 replies
11/23staging: qlge: Fix CHECK: braces {} should be used on all arms of this statementdrivers/staging/qlge/qlge_ethtool.c drivers/staging/qlge/qlge_mpi.c+18 -95 replies
12/23staging: qlge: Fix WARNING: please, no space before tabs in qlge.hdrivers/staging/qlge/qlge.h+12 -120 replies
13/23staging: qlge: Fix CHECK: spaces preferred around that (ctx:VxV)drivers/staging/qlge/qlge.h drivers/staging/qlge/qlge_main.c+12 -120 replies
14/23staging: qlge: Fix WARNING: Unnecessary space before function pointer argumentsdrivers/staging/qlge/qlge.h+2 -20 replies
15/23staging: qlge: Fix WARNING: please, no spaces at the start of a linedrivers/staging/qlge/qlge_main.c+6 -60 replies
16/23staging: qlge: Fix WARNING: Block comments use a trailing */ on a separate linedrivers/staging/qlge/qlge_main.c drivers/staging/qlge/qlge_mpi.c+8 -50 replies
17/23staging: qlge: Fix WARNING: else is not generally useful after a break or returndrivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_main.c drivers/staging/qlge/qlge_mpi.c+19 -270 replies
18/23staging: qlge: Fix CHECK: Prefer using the BIT macrodrivers/staging/qlge/qlge.h+2 -20 replies
19/23staging: qlge: Fix WARNING: msleep < 20ms can sleep for up to 20msdrivers/staging/qlge/qlge_dbg.c drivers/staging/qlge/qlge_ethtool.c drivers/staging/qlge/qlge_main.c+3 -30 replies
20/23staging: qlge: Fix CHECK: usleep_range is preferred over udelaydrivers/staging/qlge/qlge_main.c+1 -14 replies
21/23staging: qlge: Fix WARNING: suspect code indent for conditional statementsdrivers/staging/qlge/qlge_ethtool.c drivers/staging/qlge/qlge_main.c+11 -110 replies
22/23staging: qlge: Fix CHECK: Unbalanced braces around else statementdrivers/staging/qlge/qlge_mpi.c+3 -40 replies
23/23staging: qlge: Fix WARNING: Avoid multiple line dereferencedrivers/staging/qlge/qlge_main.c+5 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/23] V2: Break up from one patch to multiple

I broke up the changes from one patch to many so each patch has more defined changes. I also added a few other patches for formatting issues I missed in the original patch.

Scott Schafer (23):
staging: qlge: Fix CHECK extra blank lines in many files
staging: qlge: Fix CHECK: Alignment should match open parenthesis staging:qlge: Fix WARNING: Missing a blank line after declarations
staging: qlge: Fix WARNING: Missing a blank line after declarations
staging: qlge: Fix CHECK: Blank lines aren't necessary before a close

    brace '}'
  staging: qlge: Fix CHECK: Blank lines aren't necessary after an open
    brace '{'
  staging: qlge: Fix WARNING: quoted string split across lines
  staging: qlge: Fix CHECK: Unnecessary parentheses around
    mpi_coredump->mpi_global_header

staging: qlge: Fix CHECK: No space is necessary after a cast
staging: qlge: Fix CHECK: blank line after function/struct/union/enum
declarations
staging: qlge: Fix CHECK: braces {} should be used on all arms of this
statement
staging: qlge: Fix WARNING: please, no space before tabs in qlge.h
staging: qlge: Fix CHECK: spaces preferred around that (ctx:VxV)
staging: qlge: Fix WARNING: Unnecessary space before function pointer
arguments
staging: qlge: Fix WARNING: please, no spaces at the start of a line
staging: qlge: Fix WARNING: Block comments use a trailing */ on a
separate line
staging: qlge: Fix WARNING: else is not generally useful after a break
or return
staging: qlge: Fix CHECK: Prefer using the BIT macro
staging: qlge: Fix WARNING: msleep < 20ms can sleep for up to 20ms
staging: qlge: Fix CHECK: usleep_range is preferred over udelay
staging: qlge: Fix WARNING: suspect code indent for conditional
statements
staging: qlge: Fix CHECK: Unbalanced braces around else statement
staging: qlge: Fix WARNING: Avoid multiple line dereference

 drivers/staging/qlge/qlge.h         |  43 ++--
 drivers/staging/qlge/qlge_dbg.c     |  97 ++++----
 drivers/staging/qlge/qlge_ethtool.c |  60 ++---
 drivers/staging/qlge/qlge_main.c    | 336 +++++++++++++---------------
 drivers/staging/qlge/qlge_mpi.c     |  71 +++---
 5 files changed, 293 insertions(+), 314 deletions(-)
Signature · 1 line
2.20.1

Read the cover letter in its thread