Skip to content

dl/format-patch-notes-config-fixup: clean up some leftoverbits

Denton Liu git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2config/format.txt: clarify behavior of multiple format.notesDocumentation/config/format.txt+17 -10 replies
2/2notes: break set_display_notes() into smaller functionsbuiltin/log.c notes.c notes.h +2 more+45 -322 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] dl/format-patch-notes-config-fixup: clean up some leftoverbits

This series gives 'dl/format-patch-notes-config-fixup' a few polishing touches. First of all, we document the behaviour of multiple format.notes configuration variables so that end-users are aware of the change.

Also, Eric Sunshine suggested some cleanup in the previous round, like breaking the monolithic set_display_notes() into multiple smaller functions and not using the return value of the function to assign to show_notes.

Denton Liu (2):
config/format.txt: clarify behavior of multiple format.notes
notes: break set_display_notes() into smaller functions

 Documentation/config/format.txt | 18 +++++++++++++-
 builtin/log.c                   |  7 +++++-
 notes.c                         | 43 ++++++++++++++++++---------------
 notes.h                         | 19 +++++++++------
 revision.c                      |  6 ++---
 revision.h                      |  2 +-
 6 files changed, 62 insertions(+), 33 deletions(-)
Signature · 1 line
2.24.0.627.geba02921db