Skip to content

RFC kcov: collect coverage from usbhid interrupts

Andrey Konovalov linux-input linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2kcov: collect coverage from interruptsDocumentation/dev-tools/kcov.rst drivers/usb/gadget/udc/dummy_hcd.c include/linux/sched.h +2 more+154 -719 replies
2/2HID: usbhid: kcov: add annotations for coverage collectiondrivers/hid/usbhid/hid-core.c drivers/hid/usbhid/usbkbd.c drivers/hid/usbhid/usbmouse.c+38 -91 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchJiri Kosina
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 0/2] kcov: collect coverage from usbhid interrupts

This patchset extends kcov to allow collecting coverage from interrupts and then uses the new functionality to collect coverage from usbhid code.

What I'm not sure yet about this change is if we actually want to selectively annotate some parts of the USB stack that are executed in interrupt context, or maybe we can do this with some common approach.

For example patch #2 in this patchset annotates all functions that are passed as completion callbacks to usb_fill_*() in drivers/hid/usbhid. Maybe instead we could redefine usb_fill_*() in a way that would handle all such cases without manual annotations.

Any suggestions are welcome.

This has allowed to find at least one new HID bug [1], which was recently fixed by Alan [2].

[1] https://syzkaller.appspot.com/bug?extid=09ef48aa58261464b621
[2] https://patchwork.kernel.org/patch/11283319/

This patchset has been pushed to the public Linux kernel Gerrit instance:

https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2225

Andrey Konovalov (2):
kcov: collect coverage from interrupts
HID: usbhid: kcov: add annotations for coverage collection

 Documentation/dev-tools/kcov.rst   |  16 +--
 drivers/hid/usbhid/hid-core.c      |  25 +++-
 drivers/hid/usbhid/usbkbd.c        |  15 ++-
 drivers/hid/usbhid/usbmouse.c      |   7 +-
 drivers/usb/gadget/udc/dummy_hcd.c |   1 +
 include/linux/sched.h              |   3 +
 kernel/kcov.c                      | 196 +++++++++++++++++++----------
 lib/Kconfig.debug                  |   9 ++
 8 files changed, 192 insertions(+), 80 deletions(-)
Signature · 1 line
2.24.1.735.g03f4e72817-goog