Skip to content

Work towards removing brctl

Steven Haigh xen-devel 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 6 repliesIn review
  2. v2 posting 1/20 of 2 patches 0 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Changes in v2 from the cover letter

* Fixed reference to /usr/bin/brctl instead of /usr/sbin/brctl

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Tidy up whitespace and formatting in file to be consistent.tools/hotplug/Linux/xen-network-common.sh+70 -744 replies
2/2Use ip for bridge related functions where brctl is not presenttools/hotplug/Linux/colo-proxy-setup tools/hotplug/Linux/vif-bridge tools/hotplug/Linux/vif2 +1 more+55 -211 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchWei Liu
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Xen-devel] [PATCH v2 0/2] [PATCH-for-4.13] Work towards removing brctl

Start updating scripts for network functionality

(Resending as the patch emails seem to have been eaten somewhere)

The scripts for networking in Xen have a mixture of formatting, tab spacing, space spacing inconsistencies.

We also have issues where CentOS 8 does not have brctl - being replaced with ip / bridge commands.

This series starts cleaning up whitespace and formatting, as well as starts adding conditionals for using brctl (if present) but using ip if /usr/sbin/brctl is not installed.

Changes since v1
* Fixed reference to /usr/bin/brctl instead of /usr/sbin/brctl

Steven Haigh (2):
Tidy up whitespace and formatting in file to be consistent. Use ip for bridge related functions where brctl is not present

 tools/hotplug/Linux/colo-proxy-setup      |  30 +++--
 tools/hotplug/Linux/vif-bridge            |  19 ++-
 tools/hotplug/Linux/vif2                  |  12 +-
 tools/hotplug/Linux/xen-network-common.sh | 151 +++++++++++-----------
 4 files changed, 121 insertions(+), 91 deletions(-)
Signature · 6 lines
2.24.1

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel