Skip to content

Fixes for DP8393X SONIC device emulation

Finn Thain qemu-devel 4 versions – Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest14 patches 12 repliesApplied
  2. v314 patches 13 repliesSuperseded
  3. v213 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches25 repliesSuperseded

Changes in v4 from the cover letter

- Replaced patch 13/14 with patch suggested by Philippe Mathieu-Daudé.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/14dp8393x: Mask EOL bit from descriptor addresseshw/net/dp8393x.c+12 -70 replies
2/14dp8393x: Always use 32-bit accesseshw/net/dp8393x.c+29 -180 replies
3/14dp8393x: Clean up endianness hackshw/net/dp8393x.c+6 -110 replies
4/14dp8393x: Have dp8393x_receive() return the packet sizehw/net/dp8393x.c+5 -40 replies
5/14dp8393x: Update LLFA and CRDA registers from rx descriptorhw/net/dp8393x.c+7 -41 reply
6/14dp8393x: Clear RRRA command register bit only when appropriatehw/net/dp8393x.c+3 -40 replies
7/14dp8393x: Implement packet size limit and RBAE interrupthw/net/dp8393x.c+9 -00 replies
8/14dp8393x: Don't clobber packet checksumhw/net/dp8393x.c+1 -00 replies
9/14dp8393x: Use long-word-aligned RRA pointers in 32-bit modehw/net/dp8393x.c+6 -20 replies
10/14dp8393x: Pad frames to word or long word boundaryhw/net/dp8393x.c+28 -110 replies
11/14dp8393x: Clear descriptor in_use field to release packethw/net/dp8393x.c+10 -00 replies
12/14dp8393x: Always update RRA pointers and sequence numbershw/net/dp8393x.c+7 -50 replies
13/14dp8393x: Don't reset Silicon Revision registerhw/net/dp8393x.c+1 -11 reply
14/14dp8393x: Don't stop reception upon RBE interrupt assertionhw/net/dp8393x.c+22 -130 replies

Reviews trailers per patch

9 of 14 patches have a Reviewed-by or Acked-by.

PatchLaurent VivierPhilippe Mathieu-Daudé
1/14T-b R-b
2/14T-b
3/14T-b R-b
4/14T-b R-b
5/14T-b R-b
6/14T-b R-b
7/14T-b
8/14T-b R-b
9/14T-b R-b
10/14T-b R-b
11/14T-b
12/14T-b
13/14R-b
14/14T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation

Hi All,

There are bugs in the emulated dp8393x device that can stop packet reception in a Linux/m68k guest (q800 machine).

With a Linux/m68k v5.5 guest (q800), it's possible to remotely trigger an Oops by sending ping floods.

With a Linux/mips guest (magnum machine), the driver fails to probe the dp8393x device.

With a NetBSD/arc 5.1 guest (magnum), the bugs in the device can be fatal to the guest kernel.

Whilst debugging the device, I found that the receiver algorithm differs from the one described in the National Semiconductor datasheet.

This patch series resolves these bugs.

AFAIK, all bugs in the Linux sonic driver were fixed in Linux v5.5.
---
Changed since v1:
- Minor revisions as described beneath commit logs.
- Dropped patches 4/10 and 7/10.
- Added 5 new patches.

Changed since v2:
- Minor revisions as described beneath commit logs.
- Dropped patch 13/13.
- Added 2 new patches.

Changed since v3:
- Replaced patch 13/14 with patch suggested by Philippe Mathieu-Daudé.

Finn Thain (14):
dp8393x: Mask EOL bit from descriptor addresses
dp8393x: Always use 32-bit accesses
dp8393x: Clean up endianness hacks
dp8393x: Have dp8393x_receive() return the packet size
dp8393x: Update LLFA and CRDA registers from rx descriptor
dp8393x: Clear RRRA command register bit only when appropriate
dp8393x: Implement packet size limit and RBAE interrupt
dp8393x: Don't clobber packet checksum
dp8393x: Use long-word-aligned RRA pointers in 32-bit mode
dp8393x: Pad frames to word or long word boundary
dp8393x: Clear descriptor in_use field to release packet
dp8393x: Always update RRA pointers and sequence numbers
dp8393x: Don't reset Silicon Revision register
dp8393x: Don't stop reception upon RBE interrupt assertion

 hw/net/dp8393x.c | 202 +++++++++++++++++++++++++++++++----------------
 1 file changed, 134 insertions(+), 68 deletions(-)
Signature · 1 line
2.24.1