Skip to content

leds: lm3692x: Disable chip on brightness 0

Guido Günther linux-leds lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3leds: lm3692x: Move lm3692x_init and rename to lm3692x_leds_enabledrivers/leds/leds-lm3692x.c+35 -351 reply
2/3leds: lm3692x: Split out lm3692x_leds_disabledrivers/leds/leds-lm3692x.c+26 -161 reply
3/3leds: lm3692x: Disable chip on brightness 0drivers/leds/leds-lm3692x.c+16 -02 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPavel Machek
1/3A-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] leds: lm3692x: Disable chip on brightness 0

Otherwise there's a hardly noticeable glow even with brightness 0. Also turning off the regulator can save additional power.

This is on top of the "leds: lm3692x: Allow to set ovp and brigthness mode". Without that applied there's a minor merge conflict since this introduces a new variable in struct lm3692x_led as well. I did not want to lump it in there as well since it's not related to any DT properties at all.

Guido Günther (3):
leds: lm3692x: Move lm3692x_init and rename to lm3692x_leds_enable
leds: lm3692x: Split out lm3692x_leds_disable
leds: lm3692x: Disable chip on brightness 0

 drivers/leds/leds-lm3692x.c | 128 ++++++++++++++++++++++--------------
 1 file changed, 77 insertions(+), 51 deletions(-)
Signature · 1 line
2.23.0