Skip to content

Patch review

Armin Kuster openembedded-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17grpc: Define libdir and cmakedir in terms of multilibmeta-networking/recipes-devtools/grpc/grpc_1.24.1.bb+3 -10 replies
2/17tinyalsa: fix installation libdir path to match multilibsmeta-multimedia/recipes-multimedia/tinyalsa/tinyalsa.bb meta-multimedia/recipes-multimedia/tinyalsa/tinyalsa/0001-Use-CMAKE_INSTALL_-path-instead-of-hardcoding-bin-li.patch+49 -10 replies
3/17libqb: Add --enable-nosection-fallback with mips64/clangmeta-oe/recipes-extended/libqb/libqb_1.0.5.bb+5 -10 replies
4/17xfce-dusk-gtk3: correct invalid SRC_URImeta-xfce/recipes-art/xfce-dusk-gtk3/xfce-dusk-gtk3_1.3.bb+1 -10 replies
5/17fltk: fix build error when enable package config examplesmeta-oe/recipes-support/fltk/fltk.bb meta-oe/recipes-support/fltk/fltk/0004-Fix-build-error-when-enable-package-config-examples.patch+187 -20 replies
6/17syslog-ng: Fix multilib header conflict - syslog-ng-config.hmeta-oe/recipes-support/syslog-ng/syslog-ng.inc+3 -10 replies
7/17x11vnc: Fix build for 32bit arches with 64bit time_tmeta-oe/recipes-graphics/x11vnc/files/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch meta-oe/recipes-graphics/x11vnc/x11vnc_0.9.16.bb+114 -20 replies
8/17evtest: Fix build for 32bit arches with 64bit time_tmeta-oe/recipes-test/evtest/evtest/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch meta-oe/recipes-test/evtest/evtest_1.34.bb+45 -20 replies
9/17lirc: Fix build for 32bit arches with 64bit time_tmeta-oe/recipes-connectivity/lirc/lirc/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch meta-oe/recipes-connectivity/lirc/lirc_0.9.4d.bb+41 -00 replies
10/17utouch-evemu, utouch-frame: Fix build for 32bit arches with 64bit time_tmeta-oe/recipes-support/utouch/utouch-evemu/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch meta-oe/recipes-support/utouch/utouch-evemu_git.bb meta-oe/recipes-support/utouch/utouch-frame/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch +3 more+121 -10 replies
11/17directfb: Fix build for 32bit arches with 64bit time_tmeta-oe/recipes-graphics/directfb/directfb.inc meta-oe/recipes-graphics/directfb/directfb/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch+141 -10 replies
12/17ruli: Fix install step and build samples toometa-networking/recipes-support/ruli/files/0001-Fix-build-with-format-string-checks.patch meta-networking/recipes-support/ruli/files/0001-Make-space-for-flags-from-environment.patch meta-networking/recipes-support/ruli/files/0001-ruli_srv-Mark-prev_addr_list_size-as-unused.patch +2 more+169 -1350 replies
13/17networkmanager: Upgrade 1.18.2 -> 1.18.4meta-networking/recipes-connectivity/networkmanager/networkmanager_1.18.4.bb+2 -20 replies
14/17networkmanager: do not deploy unnecessary udev rule filemeta-networking/recipes-connectivity/networkmanager/networkmanager_1.18.4.bb+4 -10 replies
15/17gpsd: Backport a memory leak fixmeta-oe/recipes-navigation/gpsd/gpsd/0001-gps_shm_close-Free-privdata.patch meta-oe/recipes-navigation/gpsd/gpsd_3.19.bb+38 -00 replies
16/17python-more-itertools: downgrade 7.2.0 -> 5.0.0meta-python/recipes-devtools/python/python-more-itertools.inc meta-python/recipes-devtools/python/python-more-itertools_5.0.0.bb meta-python/recipes-devtools/python/python-more-itertools_7.2.0.bb +1 more+10 -50 replies
17/17libqmi: Upgrade 1.24.0 -> 1.24.2meta-oe/recipes-connectivity/libqmi/libqmi_1.24.2.bb+2 -20 replies

Reviews trailers per patch

2 of 17 patches have a Reviewed-by or Acked-by.

PatchAndreas MüllerKai Kang
1/17
2/17A-b
3/17
4/17A-b
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [zeus 00/17] Patch review

Please have comments back by Saturday.

The following changes since commit fbe4cf8d56eea586c096621e7c913b24bd99c9c6:

gtkwave: add the libtirpc dependence and config (2019-12-17 21:57:51 -0800)

are available in the Git repository at:

https://git.openembedded.org/meta-openembedded-contrib stable/zeus-nut
http://cgit.openembedded.org/meta-openembedded-contrib/log/?h=stable/zeus-nut

Adrian Bunk (3):
networkmanager: Upgrade 1.18.2 -> 1.18.4
gpsd: Backport a memory leak fix
libqmi: Upgrade 1.24.0 -> 1.24.2

Changqing Li (1):
xfce-dusk-gtk3: correct invalid SRC_URI

Hongxu Jia (1):
python-more-itertools: downgrade 7.2.0 -> 5.0.0

Kai Kang (1):
fltk: fix build error when enable package config examples

Khem Raj (9):
grpc: Define libdir and cmakedir in terms of multilib
tinyalsa: fix installation libdir path to match multilibs
libqb: Add --enable-nosection-fallback with mips64/clang
x11vnc: Fix build for 32bit arches with 64bit time_t
evtest: Fix build for 32bit arches with 64bit time_t
lirc: Fix build for 32bit arches with 64bit time_t utouch-evemu,utouch-frame: Fix build for 32bit arches with 64bit
time_t
directfb: Fix build for 32bit arches with 64bit time_t
ruli: Fix install step and build samples too

Stefan Agner (1):
networkmanager: do not deploy unnecessary udev rule file

zhangxiao (1):
syslog-ng: Fix multilib header conflict - syslog-ng-config.h

 .../recipes-multimedia/tinyalsa/tinyalsa.bb   |   4 +-
 ...L_-path-instead-of-hardcoding-bin-li.patch |  46 +++++
 ...ger_1.18.2.bb => networkmanager_1.18.4.bb} |   9 +-
 .../recipes-devtools/grpc/grpc_1.24.1.bb      |   4 +-
 ...-Fix-build-with-format-string-checks.patch |  29 ++-
 ...ake-space-for-flags-from-environment.patch |  95 +++++++++
 ...v-Mark-prev_addr_list_size-as-unused.patch |  35 ++++
 .../recipes-support/ruli/files/Makefile.patch | 122 ------------
 .../recipes-support/ruli/ruli_0.36.bb         |  23 ++-
 .../{libqmi_1.24.0.bb => libqmi_1.24.2.bb}    |   4 +-
 ...ld-on-32bit-arches-with-64bit-time_t.patch |  40 ++++
 .../recipes-connectivity/lirc/lirc_0.9.4d.bb  |   1 +
 meta-oe/recipes-extended/libqb/libqb_1.0.5.bb |   6 +-
 .../recipes-graphics/directfb/directfb.inc    |   3 +-
 ...ld-on-32bit-arches-with-64bit-time_t.patch | 139 +++++++++++++
 ...ld-on-32bit-arches-with-64bit-time_t.patch | 111 +++++++++++
 .../recipes-graphics/x11vnc/x11vnc_0.9.16.bb  |   5 +-
 .../0001-gps_shm_close-Free-privdata.patch    |  37 ++++
 meta-oe/recipes-navigation/gpsd/gpsd_3.19.bb  |   1 +
 meta-oe/recipes-support/fltk/fltk.bb          |   7 +-
 ...-when-enable-package-config-examples.patch | 182 ++++++++++++++++++
 .../recipes-support/syslog-ng/syslog-ng.inc   |   4 +-
 ...ld-on-32bit-arches-with-64bit-time_t.patch |  76 ++++++++
 .../utouch/utouch-evemu_git.bb                |   4 +-
 ...ld-on-32bit-arches-with-64bit-time_t.patch |  41 ++++
 ...tat.h-for-fixing-build-issue-on-musl.patch |   0
 .../remove-man-page-creation.patch            |   0
 .../utouch/utouch-frame_git.bb                |   1 +
 ...ld-on-32bit-arches-with-64bit-time_t.patch |  41 ++++
 meta-oe/recipes-test/evtest/evtest_1.34.bb    |   6 +-
 .../python/python-more-itertools.inc          |   3 -
 .../python/python-more-itertools_5.0.0.bb     |   7 +
 .../python/python-more-itertools_7.2.0.bb     |   2 -
 .../python/python3-more-itertools_7.2.0.bb    |   3 +
 .../xfce-dusk-gtk3/xfce-dusk-gtk3_1.3.bb      |   2 +-
 35 files changed, 935 insertions(+), 158 deletions(-)
 create mode 100644 meta-multimedia/recipes-multimedia/tinyalsa/tinyalsa/0001-Use-CMAKE_INSTALL_-path-instead-of-hardcoding-bin-li.patch
 rename meta-networking/recipes-connectivity/networkmanager/{networkmanager_1.18.2.bb => networkmanager_1.18.4.bb} (94%)
 create mode 100644 meta-networking/recipes-support/ruli/files/0001-Make-space-for-flags-from-environment.patch
 create mode 100644 meta-networking/recipes-support/ruli/files/0001-ruli_srv-Mark-prev_addr_list_size-as-unused.patch
 delete mode 100644 meta-networking/recipes-support/ruli/files/Makefile.patch
 rename meta-oe/recipes-connectivity/libqmi/{libqmi_1.24.0.bb => libqmi_1.24.2.bb} (85%)
 create mode 100644 meta-oe/recipes-connectivity/lirc/lirc/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
 create mode 100644 meta-oe/recipes-graphics/directfb/directfb/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
 create mode 100644 meta-oe/recipes-graphics/x11vnc/files/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
 create mode 100644 meta-oe/recipes-navigation/gpsd/gpsd/0001-gps_shm_close-Free-privdata.patch
 create mode 100644 meta-oe/recipes-support/fltk/fltk/0004-Fix-build-error-when-enable-package-config-examples.patch
 create mode 100644 meta-oe/recipes-support/utouch/utouch-evemu/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
 create mode 100644 meta-oe/recipes-support/utouch/utouch-frame/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
 rename meta-oe/recipes-support/utouch/{files => utouch-frame}/0001-include-sys-stat.h-for-fixing-build-issue-on-musl.patch (100%)
 rename meta-oe/recipes-support/utouch/{files => utouch-frame}/remove-man-page-creation.patch (100%)
 create mode 100644 meta-oe/recipes-test/evtest/evtest/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
 create mode 100644 meta-python/recipes-devtools/python/python-more-itertools_5.0.0.bb
 delete mode 100644 meta-python/recipes-devtools/python/python-more-itertools_7.2.0.bb
Signature · 1 line
2.17.1