Misc BDRV_SECTOR_SIZE updates
Status from this message: Thanks, applied to my block branch:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest5 patches 4 repliesApplied
- v24 patches 18 repliesSuperseded
- v13 patches 7 repliesSuperseded
Changes in v3 from the cover letter
- Patch 2: Use offset_into_cluster() instead of QEMU_IS_ALIGNED
- Patch 3: Rewrite qcow2_write_l1_entry() to use bl.request_alignment [Kevin]
- Patch 4: Remove alignment check in qcow2_co_copy_range_from()
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | qcow2: Don't round the L1 table allocation up to the sector sizeblock/ block/ block/ +1 more | +5 | 0 replies | |
| 2/5 | qcow2: Tighten cluster_offset alignment assertionsblock/ | +3 | 0 replies | |
| 3/5 | qcow2: Use bs->bl.request_alignment when updating an L1 entryblock/ | +15 | 1 reply | |
| 4/5 | qcow2: Don't require aligned offsets in qcow2_co_copy_range_from()block/ | +0 | 1 reply | |
| 5/5 | qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded valueblock/ | +5 | 1 reply |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Max Reitz |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates
This series gets rid of all the remaining instances of hardcoded sector sizes in the qcow2 code and adds a check for images whose virtual size is not a multiple of the sector size.
See the individual patches for details.
Berto
v3:
- Patch 2: Use offset_into_cluster() instead of QEMU_IS_ALIGNED
- Patch 3: Rewrite qcow2_write_l1_entry() to use bl.request_alignment [Kevin]
- Patch 4: Remove alignment check in qcow2_co_copy_range_from()
v2: https://lists.gnu.org/archive/html/qemu-block/2020-01/msg00169.html
- Modify output of iotest 080 to make it easier to understand [Nir]
- Use the QEMU_IS_ALIGNED() macro instead of the modulus operator [Nir]
- Tighten some assertions [Kevin]
v1: https://lists.gnu.org/archive/html/qemu-block/2020-01/msg00139.html
Alberto Garcia (5):
qcow2: Don't round the L1 table allocation up to the sector size
qcow2: Tighten cluster_offset alignment assertions
qcow2: Use bs->bl.request_alignment when updating an L1 entry
qcow2: Don't require aligned offsets in qcow2_co_copy_range_from()
qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value
block/qcow2-cluster.c | 30 +++++++++++++++++------------- block/qcow2-refcount.c | 2 +- block/qcow2-snapshot.c | 3 +-- block/qcow2.c | 23 +++++++++-------------- 4 files changed, 28 insertions(+), 30 deletions(-)
Signature · 1 line
2.20.1