Skip to content

Skip a connectivity check during fetch --filter

Jonathan Tan git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2connected: verify promisor-ness of partial clonebuiltin/clone.c connected.c connected.h+23 -121 reply
2/2fetch: forgo full connectivity check if --filterbuiltin/fetch.c+10 -12 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJonathan Nieder
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Skip a connectivity check during fetch --filter

The same optimization in dfa33a298d ("clone: do faster object check for partial clones", 2019-04-21) can be applied to fetch as well, so this patch set does so. Patch 1 makes the check more robust, and patch 2 applies it to one of two connectivity checks performed during the fetch.

As mentioned in patch 2, when fetching from a local repo, I got a speedup of 6.63s to 3.39s.

Jonathan Tan (2):
connected: verify promisor-ness of partial clone
fetch: forgo full connectivity check if --filter

 builtin/clone.c |  5 +++--
 builtin/fetch.c | 11 ++++++++++-
 connected.c     | 19 ++++++++++++++-----
 connected.h     | 11 ++++++-----
 4 files changed, 33 insertions(+), 13 deletions(-)
Signature · 1 line
2.25.0.rc1.283.g88dfdc4193-goog