Skip to content

ethdev: add API to dump device internal flow info

Xiaoyu Min dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesIn review
  2. v15 patches 8 repliesSuperseded

Changes in v2 from the cover letter

* Bump MLX5 PMD glue version to 20.02.0
* MLX5 PMD validate port id
* Code improvement per review comments

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ethdev: add API to dump device internal flow infolib/librte_ethdev/rte_ethdev_version.map lib/librte_ethdev/rte_flow.c lib/librte_ethdev/rte_flow.h +1 more+45 -01 reply
2/5net/mlx5: support flow dump APIdrivers/net/mlx5/Makefile drivers/net/mlx5/meson.build drivers/net/mlx5/mlx5.h +4 more+86 -20 replies
3/5app/testpmd: new flow dump CLIapp/test-pmd/cmdline_flow.c app/test-pmd/config.c app/test-pmd/testpmd.h+119 -00 replies
4/5net/mlx5: add socket server for external toolsdrivers/net/mlx5/Makefile drivers/net/mlx5/meson.build drivers/net/mlx5/mlx5.c +2 more+240 -00 replies
5/5doc: update mlx5 document for flow dump featuredoc/guides/nics/mlx5.rst+28 -00 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchOri KamViacheslav OvsiienkoFerruh Yigit
1/5A-b R-b
2/5A-b
3/5A-b
4/5A-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 0/5] ethdev: add API to dump device internal flow info

This serial patchs is based on RFC [1] and the comments on it.

A new rte flow API is added to dump device internal representation information for the offloaded rte flows.

This is very helpful for user and developer to debug flow offloading stuff, i.e, to check whether PMD offloads the rte flow in a correct way from HW perspective.

The output file is in vendor specific format. An external vendor provided tool may be needed in order to get human readable info.

[1]: https://patches.dpdk.org/cover/64597/

v2:
* Bump MLX5 PMD glue version to 20.02.0
* MLX5 PMD validate port id
* Code improvement per review comments

Xiaoyu Min (2):
ethdev: add API to dump device internal flow info net/mlx5: support flow dump API

Xueming Li (3):
app/testpmd: new flow dump CLI
net/mlx5: add socket server for external tools
doc: update mlx5 document for flow dump feature

 app/test-pmd/cmdline_flow.c              |  91 +++++++++
 app/test-pmd/config.c                    |  27 +++
 app/test-pmd/testpmd.h                   |   1 +
 doc/guides/nics/mlx5.rst                 |  28 +++
 drivers/net/mlx5/Makefile                |   8 +-
 drivers/net/mlx5/meson.build             |   5 +-
 drivers/net/mlx5/mlx5.c                  |   2 +
 drivers/net/mlx5/mlx5.h                  |   9 +
 drivers/net/mlx5/mlx5_devx_cmds.c        |  35 ++++
 drivers/net/mlx5/mlx5_flow.c             |  24 +++
 drivers/net/mlx5/mlx5_glue.c             |  13 ++
 drivers/net/mlx5/mlx5_glue.h             |   1 +
 drivers/net/mlx5/mlx5_socket.c           | 231 +++++++++++++++++++++++
 lib/librte_ethdev/rte_ethdev_version.map |   3 +
 lib/librte_ethdev/rte_flow.c             |  16 ++
 lib/librte_ethdev/rte_flow.h             |  21 +++
 lib/librte_ethdev/rte_flow_driver.h      |   5 +
 17 files changed, 518 insertions(+), 2 deletions(-)
 create mode 100644 drivers/net/mlx5/mlx5_socket.c
Signature · 1 line
2.24.1