Skip to content

drm/i915/bios: stop using vbt.ddi_port_info directly

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/i915/bios: add intel_bios_max_tmds_encoder()drivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_bios.h drivers/gpu/drm/i915/display/intel_hdmi.c+12 -51 reply
2/9drm/i915/bios: add intel_bios_hdmi_level_shift()drivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_bios.h drivers/gpu/drm/i915/display/intel_ddi.c+16 -81 reply
3/9drm/i915/bios: intel_bios_dp_boost_level()drivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_bios.h drivers/gpu/drm/i915/display/intel_ddi.c+10 -30 replies
4/9drm/i915/bios: intel_bios_hdmi_boost_level()drivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_bios.h drivers/gpu/drm/i915/display/intel_ddi.c+10 -30 replies
5/9drm/i915/bios: add intel_bios_dp_max_link_rate()drivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_bios.h drivers/gpu/drm/i915/display/intel_dp.c+11 -30 replies
6/9drm/i915/bios: add intel_bios_alternate_ddc_pin()drivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_bios.h drivers/gpu/drm/i915/display/intel_hdmi.c+16 -80 replies
7/9drm/i915/bios: add intel_bios_port_supports_*()drivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_bios.h drivers/gpu/drm/i915/display/intel_ddi.c+37 -61 reply
8/9drm/i915/bios: check port presence based on child devicedrivers/gpu/drm/i915/display/intel_bios.c+1 -36 replies
9/9drm/i915: use intel_bios_is_port_present()drivers/gpu/drm/i915/display/intel_combo_phy.c+2 -21 reply

Reviews trailers per patch

5 of 9 patches have a Reviewed-by or Acked-by.

PatchVille Syrjälä
1/9R-b
2/9R-b
3/9
4/9
5/9
6/9
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-gfx] [PATCH 0/9] drm/i915/bios: stop using vbt.ddi_port_info directly

My long term plan is to reference all post-setup VBT child device details through the encoder. We can add an (opaque) encoder->child pointer, and forgo the dance to get to the relevant VBT details. This will be helpful in, for example, adding support for multiple local panels; the data must be made encoder specific instead of just using i915->vbt.edp or i915->vbt.dsi directly.

The i915->vbt.ddi_port_info[] array stands in the way. Start hiding it in intel_bios.c. We do gain a lot of intel_bios_*() accessors which may seem noisy. But it seems to me this is a helpful iterative step no matter what.

BR,
Jani.

Jani Nikula (9):
drm/i915/bios: add intel_bios_max_tmds_encoder() drm/i915/bios: add intel_bios_hdmi_level_shift() drm/i915/bios: intel_bios_dp_boost_level() drm/i915/bios: intel_bios_hdmi_boost_level() drm/i915/bios: add intel_bios_dp_max_link_rate() drm/i915/bios: add intel_bios_alternate_ddc_pin() drm/i915/bios: add intel_bios_port_supports_*() drm/i915/bios: check port presence based on child device drm/i915: use intel_bios_is_port_present()

 drivers/gpu/drm/i915/display/intel_bios.c     | 74 ++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_bios.h     | 11 +++
 .../gpu/drm/i915/display/intel_combo_phy.c    |  4 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      | 36 ++++-----
 drivers/gpu/drm/i915/display/intel_dp.c       |  6 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     | 25 +++----
 6 files changed, 115 insertions(+), 41 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx