Fixes for SONIC ethernet driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest12 patches 1 replyIn review
- v212 patches 6 repliesSuperseded
- v119 patches 4 repliesSuperseded
Changes in v3 from the cover letter
- Minor revisions as described in commit logs.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | net/sonic: Add mutual exclusion for accessing shared statedrivers/ drivers/ | +36 | 0 replies | |
| 2/12 | net/sonic: Clear interrupt flags immediatelydrivers/ | +6 | 0 replies | |
| 3/12 | net/sonic: Use MMIO accessorsdrivers/ | +8 | 0 replies | |
| 4/12 | net/sonic: Fix interface error stats collectiondrivers/ drivers/ | +8 | 0 replies | |
| 5/12 | net/sonic: Fix receive buffer handlingdrivers/ drivers/ | +33 | 0 replies | |
| 6/12 | net/sonic: Avoid needless receive descriptor EOL flag updatesdrivers/ | +15 | 0 replies | |
| 7/12 | net/sonic: Improve receive descriptor status flag checkdrivers/ | +5 | 0 replies | |
| 8/12 | net/sonic: Fix receive buffer replenishmentdrivers/ drivers/ | +105 | 0 replies | |
| 9/12 | net/sonic: Quiesce SONIC before re-initializing descriptor memorydrivers/ drivers/ | +28 | 0 replies | |
| 10/12 | net/sonic: Fix command register usagedrivers/ | +3 | 0 replies | |
| 11/12 | net/sonic: Fix CAM initializationdrivers/ | +12 | 0 replies | |
| 12/12 | net/sonic: Prevent tx watchdog timeoutdrivers/ | +13 | 0 replies |
Reviews trailers per patch
None of the 12 patches has a Reviewed-by or Acked-by.
| Patch | Stan Johnson |
|---|---|
| 1/12 | T-b |
| 2/12 | T-b |
| 3/12 | T-b |
| 4/12 | T-b |
| 5/12 | T-b |
| 6/12 | T-b |
| 7/12 | T-b |
| 8/12 | T-b |
| 9/12 | T-b |
| 10/12 | T-b |
| 11/12 | T-b |
| 12/12 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net v3 00/12] Fixes for SONIC ethernet driver
Hi David,
Various SONIC driver problems have become apparent over the years, including tx watchdog timeouts, lost packets and duplicated packets.
The problems are mostly caused by bugs in buffer handling, locking and (re-)initialization code.
This patch series resolves these problems.
This series has been tested on National Semiconductor hardware (macsonic), qemu-system-m68k (macsonic) and qemu-system-mips64el (jazzsonic).
The emulated dp8393x device used in QEMU also has bugs. I have fixed the bugs that I know of in a series of patches at,
https://github.com/fthain/qemu/commits/sonic
---
Changed since v1:
- Minor revisions as described in commit logs.
- Deferred net-next patches.
Changed since v2:
- Minor revisions as described in commit logs.
Finn Thain (12):
net/sonic: Add mutual exclusion for accessing shared state net/sonic: Clear interrupt flags immediately net/sonic: Use MMIO accessors
net/sonic: Fix interface error stats collection net/sonic: Fix receive buffer handling
net/sonic: Avoid needless receive descriptor EOL flag updates net/sonic: Improve receive descriptor status flag check net/sonic: Fix receive buffer replenishment
net/sonic: Quiesce SONIC before re-initializing descriptor memory net/sonic: Fix command register usage
net/sonic: Fix CAM initialization
net/sonic: Prevent tx watchdog timeout
drivers/net/ethernet/natsemi/sonic.c | 380 ++++++++++++++++----------- drivers/net/ethernet/natsemi/sonic.h | 44 +++- 2 files changed, 262 insertions(+), 162 deletions(-)
Signature · 1 line
2.24.1