Skip to content

Fixes for SONIC ethernet driver

Finn Thain lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 1 replyIn review
  2. v212 patches 6 repliesSuperseded
  3. v119 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Minor revisions as described in commit logs.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12net/sonic: Add mutual exclusion for accessing shared statedrivers/net/ethernet/natsemi/sonic.c drivers/net/ethernet/natsemi/sonic.h+36 -140 replies
2/12net/sonic: Clear interrupt flags immediatelydrivers/net/ethernet/natsemi/sonic.c+6 -220 replies
3/12net/sonic: Use MMIO accessorsdrivers/net/ethernet/natsemi/sonic.h+8 -80 replies
4/12net/sonic: Fix interface error stats collectiondrivers/net/ethernet/natsemi/sonic.c drivers/net/ethernet/natsemi/sonic.h+8 -140 replies
5/12net/sonic: Fix receive buffer handlingdrivers/net/ethernet/natsemi/sonic.c drivers/net/ethernet/natsemi/sonic.h+33 -70 replies
6/12net/sonic: Avoid needless receive descriptor EOL flag updatesdrivers/net/ethernet/natsemi/sonic.c+15 -60 replies
7/12net/sonic: Improve receive descriptor status flag checkdrivers/net/ethernet/natsemi/sonic.c+5 -100 replies
8/12net/sonic: Fix receive buffer replenishmentdrivers/net/ethernet/natsemi/sonic.c drivers/net/ethernet/natsemi/sonic.h+105 -630 replies
9/12net/sonic: Quiesce SONIC before re-initializing descriptor memorydrivers/net/ethernet/natsemi/sonic.c drivers/net/ethernet/natsemi/sonic.h+28 -00 replies
10/12net/sonic: Fix command register usagedrivers/net/ethernet/natsemi/sonic.c+3 -150 replies
11/12net/sonic: Fix CAM initializationdrivers/net/ethernet/natsemi/sonic.c+12 -90 replies
12/12net/sonic: Prevent tx watchdog timeoutdrivers/net/ethernet/natsemi/sonic.c+13 -40 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by.

PatchStan Johnson
1/12T-b
2/12T-b
3/12T-b
4/12T-b
5/12T-b
6/12T-b
7/12T-b
8/12T-b
9/12T-b
10/12T-b
11/12T-b
12/12T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 00/12] Fixes for SONIC ethernet driver

Hi David,

Various SONIC driver problems have become apparent over the years, including tx watchdog timeouts, lost packets and duplicated packets.

The problems are mostly caused by bugs in buffer handling, locking and (re-)initialization code.

This patch series resolves these problems.

This series has been tested on National Semiconductor hardware (macsonic), qemu-system-m68k (macsonic) and qemu-system-mips64el (jazzsonic).

The emulated dp8393x device used in QEMU also has bugs. I have fixed the bugs that I know of in a series of patches at,
https://github.com/fthain/qemu/commits/sonic
---
Changed since v1:
- Minor revisions as described in commit logs.
- Deferred net-next patches.
Changed since v2:
- Minor revisions as described in commit logs.

Finn Thain (12):
net/sonic: Add mutual exclusion for accessing shared state net/sonic: Clear interrupt flags immediately net/sonic: Use MMIO accessors
net/sonic: Fix interface error stats collection net/sonic: Fix receive buffer handling
net/sonic: Avoid needless receive descriptor EOL flag updates net/sonic: Improve receive descriptor status flag check net/sonic: Fix receive buffer replenishment
net/sonic: Quiesce SONIC before re-initializing descriptor memory net/sonic: Fix command register usage
net/sonic: Fix CAM initialization
net/sonic: Prevent tx watchdog timeout

 drivers/net/ethernet/natsemi/sonic.c | 380 ++++++++++++++++-----------
 drivers/net/ethernet/natsemi/sonic.h |  44 +++-
 2 files changed, 262 insertions(+), 162 deletions(-)
Signature · 1 line
2.24.1