Skip to content

tracing: Updates to dynamic event API

Tom Zanussi linux-rt-users lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tracing: Consolidate some synth_event_trace codekernel/trace/trace_events_hist.c+56 -834 replies
2/4tracing: Remove check_arg() callbacks from dynevent argskernel/trace/trace_dynevent.c kernel/trace/trace_dynevent.h kernel/trace/trace_events_hist.c +1 more+46 -531 reply
3/4tracing: Remove useless code in dynevent_arg_pair_add()kernel/trace/trace_dynevent.c+1 -11 reply
4/4tracing: Use seq_buf for building dynevent_cmd stringinclude/linux/trace_events.h kernel/trace/trace_dynevent.c kernel/trace/trace_events_hist.c +1 more+16 -401 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchMasami Hiramatsu
1/4
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] tracing: Updates to dynamic event API

Hi Steve,

This patchset adds some updates to the 'tracing: Add support for in-kernel dynamic event API', on top of ftrace/core, addressing the comments from v4 of that:

- Consolidate the very similar functions synth_event_add_val/next_val() and inline find_synth_field(), as suggested by Steve

- Replace the command-building code in dynevent_cmd with equivalent seq_buf functionality, as suggested by Steve

- Move the check_arg callbacks from the arg objects and explicitly pass them to the add functions, as suggested by Masami

- Get rid of a useless bit of code in dynevent_add_arg_pair() as suggested by Masami

With these changes the dynamic event test modules work fine and the trigger selftests all pass.

Thanks,

Tom

The following changes since commit d380dcde9a07ca5de4805dee11f58a98ec0ad6ff:

tracing: Fix now invalid var_ref_vals assumption in trace action (2020-01-31 12:59:26 -0500)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/synth-event-gen-updates-v1

Tom Zanussi (4):
tracing: Consolidate some synth_event_trace code
tracing: Remove check_arg() callbacks from dynevent args
tracing: Remove useless code in dynevent_arg_pair_add()
tracing: Use seq_buf for building dynevent_cmd string

 include/linux/trace_events.h     |   4 +-
 kernel/trace/trace_dynevent.c    | 110 ++++++++++-----------------
 kernel/trace/trace_dynevent.h    |  11 ++-
 kernel/trace/trace_events_hist.c | 157 ++++++++++++++++-----------------------
 kernel/trace/trace_kprobe.c      |  12 +--
 5 files changed, 118 insertions(+), 176 deletions(-)
Signature · 1 line
2.14.1