examples: fix building with GCC 10
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | examples/vhost_blk: fix building with GCC 10examples/ examples/ | +4 | 1 reply | |
| 2/3 | examples/eventdev_pipeline: fix building with GCC 10examples/ examples/ | +4 | 0 replies | |
| 3/3 | examples/qos_sched: fix building with GCC 10examples/ examples/ | +5 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Cristian Dumitrescu | Maxime Coquelin | David Marchand |
|---|---|---|---|
| Series | A-b | A-b | |
| 1/3 | R-b | ||
| 2/3 | |||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit.
See https://gcc.gnu.org/gcc-10/porting_to.html for more informations.
I didn't put -fcommon to CFLAGS since:
Compiling with -fno-common is useful on targets for which it provides better performance, or if you wish to verify that the program will work on other systems that always treat uninitialized variable definitions this way.
from gcc man page
Timothy Redaelli (3):
examples/vhost_blk: fix building with GCC 10 examples/eventdev_pipeline: fix building with GCC 10 examples/qos_sched: fix building with GCC 10
examples/eventdev_pipeline/main.c | 2 ++ examples/eventdev_pipeline/pipeline_common.h | 4 ++-- examples/qos_sched/cfg_file.c | 3 +++ examples/qos_sched/main.h | 4 ++-- examples/vhost_blk/vhost_blk.c | 2 ++ examples/vhost_blk/vhost_blk.h | 4 ++-- 6 files changed, 13 insertions(+), 6 deletions(-)
Signature · 1 line
2.24.1