Skip to content

net: ll_temac: Bugfixes

Esben Haabendal linux-arm-kernel lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v14 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Changed error handling of of dma_map_single() in temac_start_xmit() to drop packet instead of returning NETDEV_TX_BUSY.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: ll_temac: Fix race condition causing TX hangdrivers/net/ethernet/xilinx/ll_temac_main.c+16 -30 replies
2/4net: ll_temac: Add more error handling of dma_map_single() callsdrivers/net/ethernet/xilinx/ll_temac_main.c+24 -20 replies
3/4net: ll_temac: Fix RX buffer descriptor handling on GFP_ATOMIC pressuredrivers/net/ethernet/xilinx/ll_temac.h drivers/net/ethernet/xilinx/ll_temac_main.c+82 -310 replies
4/4net: ll_temac: Handle DMA halt condition caused by buffer underrundrivers/net/ethernet/xilinx/ll_temac.h drivers/net/ethernet/xilinx/ll_temac_main.c+56 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net v2 0/4] net: ll_temac: Bugfixes

Fix a number of bugs which have been present since the first commit.

The bugs fixed in patch 1,2 and 4 have all been observed in real systems, and was relatively easy to reproduce given an appropriate stress setup.

Changes since v1:

- Changed error handling of of dma_map_single() in temac_start_xmit() to drop packet instead of returning NETDEV_TX_BUSY.

Esben Haabendal (4):
net: ll_temac: Fix race condition causing TX hang
net: ll_temac: Add more error handling of dma_map_single() calls
net: ll_temac: Fix RX buffer descriptor handling on GFP_ATOMIC
pressure
net: ll_temac: Handle DMA halt condition caused by buffer underrun

 drivers/net/ethernet/xilinx/ll_temac.h      |   4 +
 drivers/net/ethernet/xilinx/ll_temac_main.c | 209 ++++++++++++++++----
 2 files changed, 175 insertions(+), 38 deletions(-)
Signature · 1 line
2.25.0