Skip to content

Convert thermal bindings to yaml

Amit Kucheria linux-arm-msm linux-devicetree linux-pm lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 4 repliesIn review
  2. v33 patches 10 repliesSuperseded
  3. v23 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC3 patches7 repliesSuperseded

Changes in v4 from the cover letter

- Clarify example by using cooling state numbers and a comment
- Restrict thermal-sensors to a single reference to reflect actual code where there is a one-to-one mapping between sensors and thermal zones
- Add two optional properties that were missed in earlier submissions:
coefficients and sustainable-power
- Improve description of hysteresis and contribution properties
- Added Acks.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: thermal: Add yaml bindings for thermal sensorsDocumentation/devicetree/bindings/thermal/thermal-sensor.yaml+72 -02 replies
2/3dt-bindings: thermal: Add yaml bindings for thermal cooling-devicesDocumentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml+116 -01 reply
3/3dt-bindings: thermal: Add yaml bindings for thermal zonesDocumentation/devicetree/bindings/thermal/thermal-zones.yaml+341 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchRob HerringLukasz Luba
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] Convert thermal bindings to yaml

Hi all,

Here is a series splitting up the thermal bindings into 3 separate bindings in YAML, one each of the sensor, cooling-device and the thermal zones.

A series to remove thermal.txt and change over all references to it will follow shortly. Another series to fixup problems found by enforcing this yaml definition across dts files will also follow.

Changes since v3:
- Clarify example by using cooling state numbers and a comment
- Restrict thermal-sensors to a single reference to reflect actual code where there is a one-to-one mapping between sensors and thermal zones
- Add two optional properties that were missed in earlier submissions:
coefficients and sustainable-power
- Improve description of hysteresis and contribution properties
- Added Acks.

Changes since v2:
- Addressed review comment from Rob
- Added required properties for thermal-zones node
- Added select: true to thermal-cooling-devices.yaml
- Fixed up example to pass dt_binding_check

Changes since v1:
- Addressed review comments from Rob
- Moved the license back to GPLv2, waiting for other authors to give permission to relicense to BSD-2-Clause as well
- Fixed up warnings thrown by dt_binding_check

I have to add that the bindings as they exist today, don't really follow the "describe the hardware" model of devicetree. e.g. the entire thermal-zone binding is a software abstraction to tie arbitrary, board-specific trip points to cooling strategies. This doesn't fit well into the model where the same SoC in two different form-factor devices e.g. mobile and laptop, will have fairly different thermal profiles and might benefit from different trip points and mitigation heuristics. I've started some experiments with moving the thermal zone data to a board-specific platform data that is used to initialise a "thermal zone driver".

In any case, if we ever move down that path, it'll probably end up being v2 of the binding, so this series is still relevant.

Regards,
Amit

Amit Kucheria (3):
dt-bindings: thermal: Add yaml bindings for thermal sensors
dt-bindings: thermal: Add yaml bindings for thermal cooling-devices
dt-bindings: thermal: Add yaml bindings for thermal zones

 .../thermal/thermal-cooling-devices.yaml      | 116 ++++++
 .../bindings/thermal/thermal-sensor.yaml      |  72 ++++
 .../bindings/thermal/thermal-zones.yaml       | 341 ++++++++++++++++++
 3 files changed, 529 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
 create mode 100644 Documentation/devicetree/bindings/thermal/thermal-sensor.yaml
 create mode 100644 Documentation/devicetree/bindings/thermal/thermal-zones.yaml
Signature · 1 line
2.20.1