Skip to content

Add Intel ComboPhy driver

Dilip Kota linux-devicetree lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest3 patches 1 replyIn review
  2. v8 posting 2/23 patches 5 repliesSuperseded
  3. v8 posting 1/23 patches 2 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v73 patches10 repliesSuperseded
v64 patches5 repliesSuperseded
v54 patches5 repliesSuperseded
v43 patches8 repliesSuperseded
v33 patches5 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: phy: Add PHY_TYPE_XPCS definitioninclude/dt-bindings/phy/phy.h+1 -00 replies
2/3dt-bindings: phy: Add YAML schemas for Intel ComboPhyDocumentation/devicetree/bindings/phy/intel,combo-phy.yaml+101 -00 replies
3/3phy: intel: Add driver support for ComboPhydrivers/phy/intel/Kconfig drivers/phy/intel/Makefile drivers/phy/intel/phy-intel-combo.c+647 -01 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchRob Herring
1/3A-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 0/3] Add Intel ComboPhy driver

This patch series adds Intel ComboPhy driver, respective yaml schemas

Changes on v9:
Add Acked-By: Vinod Koul <[email protected]>

Fix compiler warning
drivers/phy/intel/phy-intel-combo.c:229:6: warning: cb_mode may be used uninitialized in this function [-Wmaybe-uninitialized]
ret = regmap_write(cbphy->hsiocfg, REG_COMBO_MODE(cbphy->bid), cb_mode); ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/intel/phy-intel-combo.c:204:24: note: cb_mode was declared here
enum intel_combo_mode cb_mode;

Changes on v8:
As per PHY Maintainer's request add description in comments for doing register access through register map framework.

Changes on v7:
As per System control driver maintainer's inputs remove
fwnode_to_regmap() definition and use device_node_get_regmap()

Changes on v6:
Rebase patches on the latest maintainer's branch
https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git/?h=phy-for-5.7
Dilip Kota (3):
dt-bindings: phy: Add PHY_TYPE_XPCS definition
dt-bindings: phy: Add YAML schemas for Intel ComboPhy
phy: intel: Add driver support for ComboPhy

 .../devicetree/bindings/phy/intel,combo-phy.yaml   | 101 ++++
 drivers/phy/intel/Kconfig                          |  14 +
 drivers/phy/intel/Makefile                         |   1 +
 drivers/phy/intel/phy-intel-combo.c                | 632 +++++++++++++++++++++
 include/dt-bindings/phy/phy.h                      |   1 +
 5 files changed, 749 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/intel,combo-phy.yaml
 create mode 100644 drivers/phy/intel/phy-intel-combo.c
Signature · 1 line
2.11.0