Skip to content

net: cleanup datagram receive helpers

Paolo Abeni netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- call scm_stat_del() only when not peeking - Kirill
- fix build issue with CONFIG_INET_ESPINTCP

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2unix: uses an atomic type for scm files accountinginclude/net/af_unix.h net/unix/af_unix.c+7 -161 reply
2/2net: datagram: drop 'destructor' argument from several helpersinclude/linux/skbuff.h net/core/datagram.c net/ipv4/udp.c +2 more+23 -372 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKirill TkhaiWillem de Bruijn
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] net: cleanup datagram receive helpers

Several receive helpers have an optional destructor argument, which uglify the code a bit and is taxed by retpoline overhead.

This series refactor the code so that we can drop such optional argument, cleaning the helpers a bit and avoiding an indirect call in fast path.

The first patch refactor a bit the caller, so that the second patch actually dropping the argument is more straight-forward

v1 -> v2:
- call scm_stat_del() only when not peeking - Kirill
- fix build issue with CONFIG_INET_ESPINTCP

Paolo Abeni (2):
unix: uses an atomic type for scm files accounting
net: datagram: drop 'destructor' argument from several helpers

 include/linux/skbuff.h | 12 ++----------
 include/net/af_unix.h  |  2 +-
 net/core/datagram.c    | 25 +++++++------------------
 net/ipv4/udp.c         | 14 ++++++++------
 net/unix/af_unix.c     | 28 +++++++++++-----------------
 net/xfrm/espintcp.c    |  2 +-
 6 files changed, 30 insertions(+), 53 deletions(-)
Signature · 1 line
2.21.1