Skip to content

build: Fixes for memory-debugging builds

Patrick Steinhardt grub-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2build: Fix option to explicitly disable memory debuggingconfigure.ac+5 -34 replies
2/2gnulib: Fix build of base64 when compiling with memory debugginggrub-core/lib/gnulib-patches/fix-base64.patch+6 -83 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDaniel KiperPaul Menzel
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] build: Fixes for memory-debugging builds

Hi,

this series fixes two issues I've found after investigating the build failures for LUKS2:

- Including <config-util.h> in base64.h is the wrong thing to do as it's also used in the luks2 module, which shouldn't include the util header at all.

- Ironically, explicitly disabling memory debugging enables memory debugging while it would've been disabled if just passing no option at all.

These patches fix both issues so that GRUB now builds correctly with and without memory debugging on my system.

Patrick

Patrick Steinhardt (2):
build: Fix option to explicitly disable memory debugging
gnulib: Fix build of base64 when compiling with memory debugging

 configure.ac                                  |  8 +++++---
 grub-core/lib/gnulib-patches/fix-base64.patch | 14 ++++++--------
 2 files changed, 11 insertions(+), 11 deletions(-)
Signature · 1 line
2.25.1