Skip to content

Miscellaneous fixes for resctrl selftests

Sai Praneeth Prakhya linux-kselftest lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 7 repliesIn review
  2. v113 patches 28 repliesSuperseded

Changes in v2 from the cover letter

================
1. Dropped changes to CAT test and CMT test as they will be posted in a later series.
2. Added several other fixes

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19selftests/resctrl: Rename CQM test as CMT testtools/testing/selftests/resctrl/README tools/testing/selftests/resctrl/cache.c tools/testing/selftests/resctrl/cmt_test.c +4 more+40 -400 replies
2/19selftests/resctrl: Fix typotools/testing/selftests/resctrl/cmt_test.c+1 -10 replies
3/19selftests/resctrl: Fix typo in help texttools/testing/selftests/resctrl/resctrl_tests.c+2 -20 replies
4/19selftests/resctrl: Declare global variables as externtools/testing/selftests/resctrl/resctrl.h+4 -40 replies
5/19selftests/resctrl: Return if resctrl file system is not supportedtools/testing/selftests/resctrl/resctrl_tests.c+6 -10 replies
6/19selftests/resctrl: Check for resctrl mount point only if resctrl FS is supportedtools/testing/selftests/resctrl/resctrlfs.c+3 -00 replies
7/19selftests/resctrl: Use resctrl/info for feature detectiontools/testing/selftests/resctrl/resctrl.h tools/testing/selftests/resctrl/resctrlfs.c+45 -120 replies
8/19selftests/resctrl: Ensure sibling CPU is not same as original CPUtools/testing/selftests/resctrl/resctrlfs.c+1 -10 replies
9/19selftests/resctrl: Fix missing options "-n" and "-p"tools/testing/selftests/resctrl/resctrl_tests.c+1 -10 replies
10/19selftests/resctrl: Fix MBA/MBM results reporting formattools/testing/selftests/resctrl/mba_test.c tools/testing/selftests/resctrl/mbm_test.c+18 -150 replies
11/19selftests/resctrl: Abort running tests if not root usertools/testing/selftests/resctrl/resctrl_tests.c+4 -20 replies
12/19selftests/resctrl: Enable gcc checks to detect buffer overflowstools/testing/selftests/resctrl/Makefile tools/testing/selftests/resctrl/cmt_test.c+2 -20 replies
13/19selftests/resctrl: Dynamically select buffer size for CAT testtools/testing/selftests/resctrl/cat_test.c tools/testing/selftests/resctrl/resctrl_tests.c+10 -30 replies
14/19selftests/resctrl: Skip the test if requested resctrl feature is not supportedtools/testing/selftests/resctrl/cat_test.c tools/testing/selftests/resctrl/cmt_test.c tools/testing/selftests/resctrl/mba_test.c +2 more+19 -122 replies
15/19selftests/resctrl: Change return type of umount_resctrlfs() to voidtools/testing/selftests/resctrl/resctrl.h tools/testing/selftests/resctrl/resctrlfs.c+3 -83 replies
16/19selftests/resctrl: Umount resctrl FS only if mountedtools/testing/selftests/resctrl/resctrlfs.c+4 -20 replies
17/19selftests/resctrl: Unmount resctrl FS after running all teststools/testing/selftests/resctrl/resctrl_tests.c+1 -00 replies
18/19selftests/resctrl: Fix incorrect parsing of iMC counterstools/testing/selftests/resctrl/resctrl_val.c+20 -20 replies
19/19selftests/resctrl: Fix checking for < 0 for unsigned valuestools/testing/selftests/resctrl/resctrl_val.c+17 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 00/19] Miscellaneous fixes for resctrl selftests

This patch set has several miscellaneous fixes to resctrl selftest tool that are easily visible to user. V1 had fixes to CAT test and CMT test but they were dropped in V2 because having them here made the patchset humongous. So, changes to CAT test and CMT test will be posted in another patchset.

Some warnings reported by sparse tool were fixed in this patchset but some are not yet fixed. They will be fixed in another patchset.

Patches 1 to 14, 18 and 19 are independent fixes. Patches 15 and 16 are preparatory patches for patch 17.

Thanks to Dan and David for reporting couple of issues.

V1 can be found at: https://lkml.org/lkml/2020/3/6/1249

Based on v5.7-rc6.

Changes from V1:
================
1. Dropped changes to CAT test and CMT test as they will be posted in a later series.
2. Added several other fixes

Fenghua Yu (1):
selftests/resctrl: Fix missing options "-n" and "-p"

Reinette Chatre (3):
selftests/resctrl: Fix typo
selftests/resctrl: Fix typo in help text selftests/resctrl: Ensure sibling CPU is not same as original CPU

Sai Praneeth Prakhya (15):
selftests/resctrl: Rename CQM test as CMT test selftests/resctrl: Declare global variables as extern selftests/resctrl: Return if resctrl file system is not supported selftests/resctrl: Check for resctrl mount point only if resctrl FS is
supported
selftests/resctrl: Use resctrl/info for feature detection selftests/resctrl: Fix MBA/MBM results reporting format selftests/resctrl: Abort running tests if not root user selftests/resctrl: Enable gcc checks to detect buffer overflows selftests/resctrl: Dynamically select buffer size for CAT test selftests/resctrl: Skip the test if requested resctrl feature is not
supported
selftests/resctrl: Change return type of umount_resctrlfs() to void selftests/resctrl: Umount resctrl FS only if mounted selftests/resctrl: Unmount resctrl FS after running all tests selftests/resctrl: Fix incorrect parsing of iMC counters selftests/resctrl: Fix checking for < 0 for unsigned values

 tools/testing/selftests/resctrl/Makefile      |  2 +-
 tools/testing/selftests/resctrl/README        |  4 +-
 tools/testing/selftests/resctrl/cache.c       |  4 +-
 tools/testing/selftests/resctrl/cat_test.c    |  8 +-
 .../resctrl/{cqm_test.c => cmt_test.c}        | 23 +++---
 tools/testing/selftests/resctrl/mba_test.c    | 23 +++---
 tools/testing/selftests/resctrl/mbm_test.c    | 16 ++--
 tools/testing/selftests/resctrl/resctrl.h     | 20 +++--
 .../testing/selftests/resctrl/resctrl_tests.c | 69 ++++++++++++-----
 tools/testing/selftests/resctrl/resctrl_val.c | 67 ++++++++++------
 tools/testing/selftests/resctrl/resctrlfs.c   | 77 +++++++++++++------
 11 files changed, 195 insertions(+), 118 deletions(-)
 rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (88%)
Signature · 1 line
2.19.1